Skip to content

chore: add release info artifact upload step to build workflow#50

Merged
masterwishx merged 3 commits into
mainfrom
dev-test-10
Jun 29, 2026
Merged

chore: add release info artifact upload step to build workflow#50
masterwishx merged 3 commits into
mainfrom
dev-test-10

Conversation

@masterwishx

@masterwishx masterwishx commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Signed-off-by: DaRK AnGeL 28630321+masterwishx@users.noreply.github.com

Summary by CodeRabbit

  • Bug Fixes
    • Reduced unnecessary notification messages by only sending Discord alerts in relevant release scenarios.
    • No user-facing behavior changed for successful workflows beyond cleaner notification handling.

Signed-off-by: DaRK AnGeL <28630321+masterwishx@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 55ab2352-b026-4f8c-8196-28f273ed19a2

📥 Commits

Reviewing files that changed from the base of the PR and between c2c34f4 and 66d59bb.

📒 Files selected for processing (2)
  • .github/workflows/build-fish.yml
  • .github/workflows/discord-notify.yml

📝 Walkthrough

Walkthrough

The Discord notification workflow gains an if: guard on the "Send Discord Notification" step, suppressing notifications for workflow_run events that succeed without env.NEW_RELEASE being true. A blank line is also inserted in build-fish.yml after the artifact path configuration.

CI Workflow Updates

Layer / File(s) Summary
Discord notification conditional guard
.github/workflows/discord-notify.yml, .github/workflows/build-fish.yml
Adds an if: condition to skip Discord notifications on workflow_run success when env.NEW_RELEASE is not true; inserts a cosmetic blank line in the build workflow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐇 A rabbit checks the release news,
No tag today? Then mute those queues!
The Discord bell won't ring in vain,
For silent builds that leave no trace.
Only fresh fish make the waves! 🐟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main workflow change by referring to the release info artifact upload step in the build workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-test-10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…failure scenarios

Signed-off-by: DaRK AnGeL <28630321+masterwishx@users.noreply.github.com>
Signed-off-by: DaRK AnGeL <28630321+masterwishx@users.noreply.github.com>
@masterwishx masterwishx merged commit 46ee40f into main Jun 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant