Skip to content

ci(public): catch broken Getting Started, support and landing links before merge - #318

Merged
masarray merged 2 commits into
mainfrom
ci/public-navigation-integrity-20261024
Oct 24, 2026
Merged

masarray merged 2 commits into
mainfrom
ci/public-navigation-integrity-20261024

Conversation

@masarray

Copy link
Copy Markdown
Owner

Adds a zero-dependency Python acceptance gate for local links in user-facing README, Getting Started, Support, Studio, feature matrix and developer index; also checks product page section anchors. Runs on relevant PRs and pushes. It complements the existing live-browser/release tests, without changing runtime, firmware, release binaries or user-facing claims. The gate permits optional guides not yet on main; after #316 lands it checks them automatically. Merge after the GitHub Actions check passes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T11:34:28.682662Z 05baee7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05baee72d9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +89 to +90
if url.fragment and unquote(url.fragment) not in sections:
issues.append(f"index.html: missing section {raw}")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Resolve landing-page fragments against their target document

When a landing-page link includes both a local path and a fragment, this checks the fragment against IDs in index.html rather than anchors in the linked document. Consequently, a valid link such as docs/INSTALL.md#windows fails even when that target contains a Windows heading, while a broken destination fragment can pass if its name happens to match a landing-page ID. Restrict the current sections check to same-page links and validate cross-document fragments against the resolved target.

Useful? React with 👍 / 👎.

@masarray
masarray merged commit 8aa6bab into main Oct 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant