Repository navigation
fix(studio): restore one-click injection and simplify premium operator GUI - #214
Conversation
…ibbon UI and compact menus
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 014ab8a8a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function onRunningChanged() { | ||
| if (ribbon.device.running) { | ||
| ribbon.startQueued = false | ||
| startWatchdog.stop() | ||
| controller.pendingApply = false |
There was a problem hiding this comment.
If the operator changes a signal after clicking Start but before the board reports RUNNING, the queued snapshot still contains the old value and the editable controls do not transmit the new value because pendingApply remains true. This handler then unconditionally clears pendingApply, so the UI displays the new setpoint while the physical publisher runs the earlier one. Preserve a scenario revision across the asynchronous transition or disable edits until START is confirmed.
AGENTS.md reference: AGENTS.md:L74-L86
Useful? React with 👍 / 👎.
| ToolTip.text: text | ||
| HoverHandler { id: evidenceHover } | ||
| } | ||
|
|
There was a problem hiding this comment.
Removing this label makes the repository's operator-workspace gate fail unconditionally: check_operator_workspace.py still requires both SIMULATED metadata and sample phase needs independent verification, and .github/workflows/arstack-studio-qt.yml runs that script. Running python3 apps/arstack_studio/tests/check_operator_workspace.py at this commit exits with SV simulation must never masquerade as independently proven lock, so the Studio CI cannot pass until equivalent evidence text is retained or the contract is deliberately reconciled.
AGENTS.md reference: AGENTS.md:L230-L236
Useful? React with 👍 / 👎.
Exact-head acceptance update —
|
1 participant
Package A · Fast workflow recovery / operator screenshots
The current preview regressed to mandatory Apply to board → Start and undersized ribbon actions. The operator asked to remove Apply entirely, enlarge commands, fix white-hover contrast, compact action menus, reclaim dead space and place state in one footer.
Exact source head:
014ab8a8a932d1205e63d1f95d13f0d9e701d382. One source commit, 23 files, no firmware changes.One-click electrical workflow (safety-critical)
SmartSessionController::requestStartWithScenariowhen a local draft is pending. One complete snapshot includes frequency, all 8 magnitude/phase/quality/enable states, CT shaping and START.Premium operator UI
No ESP32 board detected · Preview mode onlywhen offline and device/PTP/smpSynch/telemetry when connected. Non-error operations log and show in footer instead of flying toast.Exact-head acceptance
Wait for Qt normal/HiDPI smoke (zero TypeError/ReferenceError), deterministic session harness, Windows lifecycle viewport 960×620/1240×760/1440×900 at 100/150/175% DPI, product naming, RC2 and Native Preview/Inno. Do not rerun or edit for cosmetics while jobs are green/in flight. Review actual Windows screenshots plus physical ESP32/PTP+SV capture before declaring stable release.