Repository navigation
M2N: native Browser GOOSE Subscribe with exact wire-observed DataSet values - #200
Merged
masarray merged 8 commits intoOct 16, 2026
Merged
Conversation
…and exact stream identity
…ction and retained capture state
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96cc466b7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone M2N/G1: wire-observed GOOSE subscribe directly in native Workbench Browser
Baseline
main ce92154c5c465de644704d1b1a1897e9399ac04c. The reported product blocker is reproducible in source:BrowserGoosePane.qmlonly showedcontext.gooseStreamsSCL attributes and no observed allData, whereas a workingGooseMonitorController, Linux AF_PACKET/Npcap subscriber, frame decoding, bounded stream monitoring, and PCAP export already exist in the Sniffer.Reference port, without duplication
Cross-checked
masarray/arsasdocs/GOOSE_SUBSCRIBER.md,Services/GooseSubscriberRuntime.cs,Views/GooseSubscriberLiteView.xaml; andmasarray/ARIEC61850GooseFrameParser.cs. Ported ARSAS operator interaction and exact-wire binding priority into the existing C++/QML Workbench. No WPF/.NET engine transplant, second Ethernet listener, separate decoder, capture thread, or duplicate SCL authority.End-to-end behavior
GooseMonitorControlleris passed to each Browser tab as a shared read-only observation authority, not instantiated per IED. Sniffer and Browser see the same received frames and supervision events.GOOSE Subscribeaction with NIC selection and capture status; no default arbitrary NIC, no MMS Read/Write/GOOSE publish/GSEControl toggle. Starts existing passive capture; Stop halts that shared capture. Npcap capability checks remain delegated to transport.observedForStreamresolves exact case-sensitivegoCBRef, then enforces all known SCL/live DataSet reference, hexadecimal APPID and destination MAC constraints. Never APPID-only; malformed constraints, missing goCBRef, multiple matching publishers all fail closed.allDatavalues beside SCL's ordered DataSet members; count mismatch suppresses false signal-to-value assignment. Unbound raw allData is still visible without fabricated names; source separation across Browser fleet is maintained. Stopped capture never falsely displays as live.Regression and gates
Extended native
ied_goose_workspace_qaagainst existing captured publisher PCAP: correct identity and allData order; case-sensitive ref, wrong DataSet, malformed/wrong APPID, invalid/wrong destination MAC all rejected; second publisher with same ref+APPID but other source/MAC is ambiguous unless explicitly disambiguated by MAC. Existing 256-stream/256-member/rejection/TAL/PCAP tests preserved. Source-level GUI contract and rendered Qt gates required, plus Windows Build.Acceptance still open: physical relay/Npcap NIC visibility, VLAN/offload/switch mirroring, true GOOSE publish and installed Windows package screenshot. Do not claim field capture until tested.