Skip to content

M2N: native Browser GOOSE Subscribe with exact wire-observed DataSet values - #200

Merged
masarray merged 8 commits into
mainfrom
feat/workbench-goose-subscribe-live-binding-20261016
Oct 16, 2026
Merged

masarray merged 8 commits into
mainfrom
feat/workbench-goose-subscribe-live-binding-20261016

Conversation

@masarray

Copy link
Copy Markdown
Owner

Milestone M2N/G1: wire-observed GOOSE subscribe directly in native Workbench Browser

Baseline main ce92154c5c465de644704d1b1a1897e9399ac04c. The reported product blocker is reproducible in source: BrowserGoosePane.qml only showed context.gooseStreams SCL attributes and no observed allData, whereas a working GooseMonitorController, Linux AF_PACKET/Npcap subscriber, frame decoding, bounded stream monitoring, and PCAP export already exist in the Sniffer.

Reference port, without duplication

Cross-checked masarray/arsas docs/GOOSE_SUBSCRIBER.md, Services/GooseSubscriberRuntime.cs, Views/GooseSubscriberLiteView.xaml; and masarray/ARIEC61850 GooseFrameParser.cs. Ported ARSAS operator interaction and exact-wire binding priority into the existing C++/QML Workbench. No WPF/.NET engine transplant, second Ethernet listener, separate decoder, capture thread, or duplicate SCL authority.

End-to-end behavior

  • Main's one GooseMonitorController is passed to each Browser tab as a shared read-only observation authority, not instantiated per IED. Sniffer and Browser see the same received frames and supervision events.
  • Browser → GOOSE gains explicit GOOSE Subscribe action with NIC selection and capture status; no default arbitrary NIC, no MMS Read/Write/GOOSE publish/GSEControl toggle. Starts existing passive capture; Stop halts that shared capture. Npcap capability checks remain delegated to transport.
  • observedForStream resolves exact case-sensitive goCBRef, then enforces all known SCL/live DataSet reference, hexadecimal APPID and destination MAC constraints. Never APPID-only; malformed constraints, missing goCBRef, multiple matching publishers all fail closed.
  • Browser exposes observed APPID, st/sq, frame count, TAL timeout and decoded allData values beside SCL's ordered DataSet members; count mismatch suppresses false signal-to-value assignment. Unbound raw allData is still visible without fabricated names; source separation across Browser fleet is maintained. Stopped capture never falsely displays as live.
  • Retains existing SCL/model attributes for offline use; Sniffer remains full capture view and PCAP export.

Regression and gates

Extended native ied_goose_workspace_qa against existing captured publisher PCAP: correct identity and allData order; case-sensitive ref, wrong DataSet, malformed/wrong APPID, invalid/wrong destination MAC all rejected; second publisher with same ref+APPID but other source/MAC is ambiguous unless explicitly disambiguated by MAC. Existing 256-stream/256-member/rejection/TAL/PCAP tests preserved. Source-level GUI contract and rendered Qt gates required, plus Windows Build.

Acceptance still open: physical relay/Npcap NIC visibility, VLAN/offload/switch mirroring, true GOOSE publish and installed Windows package screenshot. Do not claim field capture until tested.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T11:33:50.165180Z 96cc466 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96cc466b7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/ied_simulator/src/GooseMonitorController.cpp
Comment thread apps/ied_simulator/qml/BrowserGoosePane.qml Outdated
Comment thread apps/ied_simulator/qml/BrowserGoosePane.qml
@masarray
masarray merged commit 7158065 into main Oct 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant