Skip to content

Only load Steam API if Steam license type is set in loadConfig - #7

Open
InvoxiPlayGames wants to merge 2 commits into
marzent:nativeAOTfrom
InvoxiPlayGames:nativeAOT
Open

Only load Steam API if Steam license type is set in loadConfig#7
InvoxiPlayGames wants to merge 2 commits into
marzent:nativeAOTfrom
InvoxiPlayGames:nativeAOT

Conversation

@InvoxiPlayGames

Copy link
Copy Markdown

avoids having XIV on Mac open "holding up" the Steam account for players with Windows or Mac licenses, which prevents Steam from launching games on other computers. ideally, SteamAPI would only be initialised when launching the game so Steam license type users aren't affected either

i haven't been able to test if this commit breaks the launcher for Steam licenses but i assume it won't

@marzent

marzent commented Jul 4, 2024

Copy link
Copy Markdown
Owner

You can still leave the steam initialization inside Init() the config is already loaded at that point in time

@InvoxiPlayGames

Copy link
Copy Markdown
Author

i moved the Steam initialisation into loadConfig, because, as hacky as it is, the launcher only calls initXL once, however loadConfig is called when a configuration option changes, like selecting a different license type in settings / during first-time setup. trying to launch the game with a Steam license if the app first launched without it set would just fail

although i just noticed SteamSqexLauncher.Login initialises Steam if it isn't already initialised, so maybe i could move the Steam variable assignment / library loading to initXL and rely on SteamSqexLauncher to initialise it when its needed if that's more ideal?

@marzent

marzent commented Jul 4, 2024

Copy link
Copy Markdown
Owner

rely on SteamSqexLauncher to initialise it when its needed if that's more ideal?

Yeah, that's the idea.
Theoretically it is not needed at all on startup but it can delay the login otherwise for steam licenses.

@ReddishBearGames

Copy link
Copy Markdown

This would break the ability to use a Mac/Windows license and passively have your activity tracked on Steam - which is what I used it for :D

A setting to opt in/out of optional Steam check-in might be better than tying it entirely to license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants