https verification and api key authentication - #1
Open
martijnf1 wants to merge 2 commits into
Open
Conversation
added 2 commits
September 10, 2025 21:12
username/password combination
modifying requests will be made when in check mode. Also fixed a bug where when headers or verify was already present in the kwargs to requests, we would overwrite it. Another argument allows bypassing the addition of authentication headers alltogether, which is required for the initial setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added both https verification and api key authentication to the code. For this i had to make username/password optional.
I also refactored the multiple calls to request() so that the call can be decorated in one place, which makes future changes easier.
I have not touched most of the username/password auth code, but i made the jwt token part of the Portainer object so that it does not have to be passed around all the time.
Could you verify that the username/password authentication still works before merging this, i do not have an instance of portainer at hand that allows it.