Repository navigation
Make wallet creation idempotent to prevent accidental destination cha… - #25
Open
jeffreyjoseph931-ship-it wants to merge 1 commit into
Conversation
…nges - Add is_active column to wallets table with unique partial index to enforce one-active-wallet-per-merchant invariant - Implement idempotent create_wallet() that returns existing active wallet on retry instead of creating duplicates - Update wallet_by_merchant() to return active wallet for payment requests and other operations - Use transactions to ensure atomicity of wallet creation - Add comprehensive tests covering idempotency, concurrency safety, and payment request integration - Update API.md documentation with clear idempotency statement Fixes issue where repeated wallet-create calls silently changed the destination address used by new payment requests. Now retries safely return the same wallet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nges
Fixes issue where repeated wallet-create calls silently changed the destination address used by new payment requests. Now retries safely return the same wallet.
closes #10