feat(client): auto-advance to next event on Save (Cluster D) - #38
Merged
Conversation
After Save commits the model, step to the next event automatically — Save is the 'done with this event' action (Erin asked for auto-advance after saving a ligand). Deliberately NOT on Merge: merging the ligand is mid-workflow (you then edit/refine the protein WITH the ligand present so it senses the steric context); Save is the finalize-and-move-on step. Wired via a goAdjacentRef since saveModel is defined above goAdjacent; advances from the current event and no-ops at the end of the list. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cluster D — workflow. Auto-advance through events, on Save (not Merge).
What
After
saveModelcommits the model, advance to the next event automatically — Erin asked for auto-advance after saving a ligand.Why Save, not Merge
Merging the ligand is mid-workflow: you then edit/refine the protein with the ligand present (so it senses the ligand's steric context). Save is the finalize-and-move-on step. So Merge stays put; Save advances. (Legacy Coot-based
pandda.inspecttreated "merge" as the terminal action — if reviewers genuinely split on the convention, a small preference toggle is the follow-up rather than hard-coding one.)Wired via a
goAdjacentRefsincesaveModelis defined abovegoAdjacent; advances from the current event and no-ops at the end of the list.Answered along the way (Erin's question)
"Does merge also automatically save model edits?" — Yes.
commitLiveModelexports the entire live model (getAtoms("pdb")), so any Moorhen edits (waters, rotamers, alt-confs, occupancy) are persisted in both Merge and Save; themergeflag only addspose_merged+ the hit assertion.Verification
tsc clean. In-app: Merge keeps you on the event (ligand in model); Save advances to the next; Save on the last event no-ops.
🤖 Generated with Claude Code