feat: Cluster C — decision/site legibility (analysed count, decision icons, stacked site chart) - #37
Merged
Merged
Conversation
A built/hit badge alone made a partly-reviewed site look fully analysed (Erin: 'it makes it look like I've analysed all the events at the site... could you list the number analysed'). Add an analysed-count chip beside the event count: amber while events remain unreviewed (decision==unreviewed), green when the whole site is decided, with a 'N still to analyse' tooltip. Reuses the existing decision!=unreviewed definition (grouping.decisionTally). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
no_hit and ambiguous events shared the generic view icon, so they read as unreviewed (Erin: 'no hit and ambiguous didn't always show status'). Make the icon carry the decision: hit=check, no_hit=cancel (X), ambiguous=help (?), unreviewed=cube. Build status stays on the chip border, so no new chips — the icon just becomes legible per decision. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The 'events per site' chart overlaid only Events + Hits, so no-hit and ambiguous never showed (Erin: 'no hits/ambiguous don't show up on the dashboard graphs'). Make it a STACKED bar per site — hit/no-hit/ambiguous/ unreviewed segments summing to the event count — so the full decision mix and curation progress read off one axis (and it's less busy than overlaid bars). Backend per-site rollup now emits n_no_hit/n_ambiguous (additive); client SiteSummary + chart consume them. Colours mirror the event-chip decision semantics. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Erin/crystallographer feedback, Cluster C (decision & site legibility). Three small, related changes.
C1 — per-site "analysed N/total" count (the screenshot ask)
A built/hit badge alone made a partly-reviewed site look fully analysed. Group headers now carry an
N/total analysedchip next to the event count — amber while events remain unreviewed, green when the site is fully decided, with a "K still to analyse" tooltip. Reuses the existingdecision !== "unreviewed"definition.C2 — distinct decision icons on event chips
no_hitandambiguousshared the generic view icon, so they read as unreviewed. The icon now carries the decision: hit = check, no-hit = ✕ (Cancel), ambiguous = ? (Help), unreviewed = cube. Build status stays on the chip border — no new chips.C3 — per-site chart stacked by decision
The "events per site" chart overlaid only Events + Hits, so no-hit/ambiguous never showed. It's now a stacked bar per site (hit / no-hit / ambiguous / unreviewed summing to the event count) — surfaces the full decision mix and curation progress on one axis, and is less busy than overlaid bars.
n_no_hit/n_ambiguous(additive; 119 tests pass).SiteSummarytype + stacked chart.Not done (deliberately)
Chip density on the dtag card was noted but left alone — declutter waits for the crystallographer to name what's noise rather than guessing.
Verification
tsc clean; backend tests pass (119, 4 skipped). Verified in-app: analysed counts tick/colour correctly, decision icons distinct, stacked chart updates as events are decided.
🤖 Generated with Claude Code