Skip to content

chore(hosting): drop the note under the analytics panels - #177

Merged
martian56 merged 1 commit into
martian56:mainfrom
cavidelizade:chore/drop-analytics-footnote
Aug 21, 2026
Merged

chore(hosting): drop the note under the analytics panels#177
martian56 merged 1 commit into
martian56:mainfrom
cavidelizade:chore/drop-analytics-footnote

Conversation

@cavidelizade

@cavidelizade cavidelizade commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Removes the paragraph under the analytics panels:

Counted from the server's own request logs for SkyBound, so nothing has to be added to your pages. A visit is a page that was successfully served: images, stylesheets, redirects and errors are not counted as reading, and neither are crawlers — all of them still count towards bandwidth. Updated periodically rather than live.

It was methodology, and methodology belongs with whoever maintains this rather than on the page of whoever owns the website. The panels say what they are.

Info and TrendingUp are no longer imported, and website is no longer read — it stays in the props so the call site is unchanged.

The test that checked the note did not overclaim now checks there is no note at all.

Verified

Opened the tab and confirmed the paragraph is gone and the panels are unchanged — Device Types still reads Desktop 90% · 9, Mobile 10% · 1 from the same rows.

lint:undef, typecheck, test (851) and build all pass — the four steps CI actually blocks on.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • Simplified the website analytics view by removing the informational analytics-source panel and related explanatory text.
    • Improved the interface by eliminating unused visual elements and reducing unnecessary clutter.
    • Updated automated checks to reflect the streamlined analytics presentation.

It explained where the figures came from, what counts as a visit and what does
not, and that they update on a timer. None of that needs to be on the page —
the panels say what they are, and a paragraph of methodology under them is for
whoever maintains this, not for whoever owns the website.

`Info` and `TrendingUp` went with it, and the `website` prop is no longer read;
it stays in the props so the call site is unchanged.

The test that checked the note did not overclaim now checks there is no note.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 46c67f56-d326-42f6-94f2-109a03fd7f68

📥 Commits

Reviewing files that changed from the base of the PR and between b89af1c and b063a97.

📒 Files selected for processing (2)
  • frontend/src/features/hosting/WebsiteAnalyticsTab.test.tsx
  • frontend/src/features/hosting/WebsiteAnalyticsTab.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The analytics tab removes its informational source panel and unused imports. The existing website prop remains required by the call site. The test now verifies that the removed explanatory copy is absent.

Changes

Analytics panel removal

Layer / File(s) Summary
Remove analytics source panel
frontend/src/features/hosting/WebsiteAnalyticsTab.tsx, frontend/src/features/hosting/WebsiteAnalyticsTab.test.tsx
The component no longer renders the analytics-source panel or uses the website prop internally. The test verifies that related explanatory text is absent.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to b063a

This localized UI-only change removes explanatory text while leaving the analytics panels unchanged; the described browser verification and automated checks support merging with no actionable merge-blocking risk remaining.

Suggested reviewers: martian56

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the note below the analytics panels.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@martian56
martian56 merged commit 6ebded9 into martian56:main Aug 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants