Rebuild the site around the benchmark comparison - #78
Open
martian56 wants to merge 1 commit into
Open
Conversation
The page now opens on the four-engine table instead of a claim, with the commit, date and container limits attached to it, and the workloads QuantaDB loses shown at the same weight as the ones it wins. The field and machine tables are written by CI. readme_bench.py rewrites the marked blocks in web/index.html from the same result artifacts it already uses for the readme, so the two can never disagree, and the bench workflow commits both. Protocol copy now matches the code on this branch: one native protocol on 6626, no psql quickstart, no Postgres wire claim. The field runs predate that change and say so on the page. Adds PRODUCT.md and DESIGN.md recording the direction and the rules the build follows.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds
web/on top ofquanta-port, so the site can describe the nativeprotocol instead of the PostgreSQL wire protocol that branch removes.
What changed
The page opens on the four-engine comparison rather than a claim. The table
sits in the first viewport at full width with its commit, date and container
limits attached, and the workloads QuantaDB loses are drawn at the same
weight as the ones it wins. PostgreSQL's write lead is marked, not buried.
Structure varies section to section instead of repeating one rig: the field
table, the five-machine matrix, a prose pair on the engine, two code blocks,
and the milestone list.
The tables are CI output now
readme_bench.pygained a second target. It rewrites the marked blocks inweb/index.htmlfrom the same result artifacts it already uses for thereadme, so the published numbers cannot drift apart, and
bench.ymlcommitsboth files. Verified idempotent: running the publisher twice against fixture
data produces identical output.
The five-machine table is now ordered by write throughput, which puts the
Windows runner and its 540 ops/s at the bottom where the callout reads
correctly. A profile is flagged when its writes fall below a quarter of the
best profile's or its write tail passes 20 ms.
Protocol copy
No
psqlquickstart, no "Speaks PostgreSQL" card, no Postgres wire claim.The quickstart builds from source, because there is still no published
image, and connects over TCP on 6626.
One thing reviewers should look at
The field numbers were produced by driving QuantaDB through its
PostgreSQL-compatible port with psycopg2, which is what
field_bench.pystill does. That port does not exist on this branch. The measurements are
real and the engine path behind them is unchanged, but the comparison is not
reproducible against this commit until
reference.ymlandfield_bench.pyare re-pointed at the native client. The page states this in place rather
than implying the run is current. That harness work is still open.
Supersedes #76.