Skip to content

Drop a misbehaving paired baseline instead of failing the run #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martian56 merged 1 commit into from
Jul 25, 2026
Merged

Drop a misbehaving paired baseline instead of failing the run #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,19 @@ jobs:
"$loadgen" --seconds 10 --connections 4 --rows 5000 --read-percent "$2" > pass.txt
cat pass.txt
python .github/scripts/parse_loadgen.py "$1" pass.txt >> "${{ matrix.profile }}.jsonl"
# A baseline that misbehaves drops out; the report falls back
# to the cross run one rather than failing the job.
if [ -n "$BASE_SERVER" ]; then
"$BASE_LOADGEN" --seconds 10 --connections 4 --rows 5000 \
--read-percent "$2" --address 127.0.0.1:54322 > base.txt
python .github/scripts/parse_loadgen.py "$1" base.txt \
>> "base/${{ matrix.profile }}.jsonl"
if "$BASE_LOADGEN" --seconds 10 --connections 4 --rows 5000 \
--read-percent "$2" --address 127.0.0.1:54322 > base.txt \
&& python .github/scripts/parse_loadgen.py "$1" base.txt \
>> "base/${{ matrix.profile }}.jsonl"; then
:
else
echo "baseline pass failed; dropping the paired baseline"
rm -f "base/${{ matrix.profile }}.jsonl"
BASE_SERVER=""
fi
fi
done
}
Expand Down
Loading