Skip to content

fix: Base null safety 및 fluent API 개선 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sinwoojin wants to merge 1 commit into
base: main
Choose a base branch
from
+49 −116
Open

fix: Base null safety 및 fluent API 개선 #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
165 changes: 49 additions & 116 deletions packages/rune/src/Base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,182 +1,119 @@
import { eventHelper } from './EventHelper';
import { rune } from './rune';
import type { CustomEventInitFromClass } from './CustomEventWithDetail';
import { eventHelper } from './EventHelper';
import { _camelToColonSeparated } from './lib/_camelToColonSeparated';
import { rune } from './rune';

export abstract class Base {
protected _element: HTMLElement | null = null;
private _runeElNumber = 0;
private _isTempElId = false;
protected _element?: HTMLElement;
private _tempElId?: string;

protected onRender() {}
protected onMount() {}
protected onUnmount() {}

protected _onRender(): this {
rune.set(this.element(), this);
eventHelper.addDecoratedListeners(this, this.element());
const el = this.element();
rune.set(el, this);
eventHelper.addDecoratedListeners(this, el);
this.onRender();
eventHelper.addReservedListener(this, this.element());
eventHelper.addReservedListener(this, el);
return this;
}

protected onMount() {}

protected _onMount(): this {
this.onMount();
return this;
}

protected onUnmount() {}

protected _onUnmount() {
protected _onUnmount(): this {
this.onUnmount();
return this;
}

protected _setElement(element: HTMLElement): this {
this._element = element;
return this;
}

element(): HTMLElement {
if (this._element === null) {
if (!this._element) {
throw new TypeError("element is not created. call 'view.render' or 'view.hydrateFromSSR'.");
}
return this._element;
}

isRendered(): boolean {
return this._element !== null;
return !!this._element;
}

chain(f: (this: this, view: this) => void): this {
f.call(this, this);
chain(f: (view: this) => void): this {
f(this);
return this;
}

async chainAsync(f: (this: this, view: this) => Promise<void>): Promise<this> {
await f.call(this, this);
async chainAsync(f: (view: this) => Promise<void>): Promise<this> {
await f(this);
return this;
}

safely(f: (this: this, view: this) => void): this {
safely(f: (view: this) => void): this {
return this.isRendered() ? this.chain(f) : this;
}

async safelyAsync(f: (this: this, view: this) => Promise<void>): Promise<this> {
async safelyAsync(f: (view: this) => Promise<void>): Promise<this> {
return this.isRendered() ? this.chainAsync(f) : this;
}

protected _getElId() {
if (this.element().id) {
return this.element().id;
} else {
this._isTempElId = true;
return (this.element().id = `rune-temp-id-${++this._runeElNumber}`);
protected _getElId(): string {
const el = this.element();
if (el.id) return el.id;

if (!this._tempElId) {
this._tempElId = `rune-temp-id-${crypto.randomUUID()}`;
el.id = this._tempElId;
}
return el.id;
}

protected _removeTempElId(): this {
if (this._isTempElId) {
this.element().removeAttribute('id');
this._isTempElId = false;
if (this._tempElId && this._element?.id === this._tempElId) {
this._element.removeAttribute('id');
}
this._tempElId = undefined;
return this;
}

protected _setElement(element: HTMLElement): this {
this._element = element;
return this;
}

/* eslint-disable @typescript-eslint/no-explicit-any */
addEventListener<T extends new (...args: any[]) => Event>(
eventType: T,
listener: (this: this, ev: InstanceType<T>) => any,
options?: boolean | AddEventListenerOptions,
): this;
addEventListener<K extends keyof HTMLElementEventMap>(
eventType: K,
listener: (this: this, ev: HTMLElementEventMap[K]) => any,
options?: boolean | AddEventListenerOptions,
): this;
addEventListener(
eventType: string,
listener: (this: this, ev: Event) => any,
listener: (this: this, ev: HTMLElementEventMap[K]) => void,
options?: boolean | AddEventListenerOptions,
): this;
addEventListener(eventType: any, listener: any, options?: any): this {
eventHelper.addEventListener(this, this._element, eventType, listener, options);
): this {
eventHelper.addEventListener(this, this.element(), eventType, listener, options);
return this;
}

removeEventListener<T extends new (...args: any[]) => Event>(
eventType: T,
listener: (this: this, ev: InstanceType<T>) => any,
options?: boolean | AddEventListenerOptions,
): this;
removeEventListener<K extends keyof HTMLElementEventMap>(
eventType: K,
listener: (this: this, ev: HTMLElementEventMap[K]) => any,
listener: (this: this, ev: HTMLElementEventMap[K]) => void,
options?: boolean | EventListenerOptions,
): this;
removeEventListener(
eventType: string,
listener: (this: this, ev: Event) => any,
options?: boolean | EventListenerOptions,
): this;
removeEventListener(eventType: any, listener: any, options?: any): this {
eventHelper.removeEventListener(this, this._element, eventType, listener, options);
): this {
eventHelper.removeEventListener(this, this.element(), eventType, listener, options);
return this;
}

delegate<K extends new (...args: any[]) => Event, T extends new (...args: any[]) => Base>(
eventClass: K,
View: T,
listener: (
this: this,
e: InstanceType<K> & { originalEvent: InstanceType<K> },
targetView: InstanceType<T>,
) => void,
): this;
delegate<K extends new (...args: any[]) => Event>(
eventClass: K,
selector: string,
listener: (this: this, e: InstanceType<K> & { originalEvent: InstanceType<K> }) => void,
): this;
delegate<K extends keyof HTMLElementEventMap, T extends new (...args: any[]) => Base>(
eventType: K,
View: T,
listener: (
this: this,
e: HTMLElementEventMap[K] & { originalEvent: HTMLElementEventMap[K] },
targetView: InstanceType<T>,
) => void,
): this;
delegate<K extends keyof HTMLElementEventMap>(
eventType: K,
selector: string,
listener: (
this: this,
e: HTMLElementEventMap[K] & { originalEvent: HTMLElementEventMap[K] },
) => void,
): this;
delegate<T extends new (...args: any[]) => Base>(
eventType: string,
View: T,
listener: (
this: this,
e: Event & { originalEvent: Event },
targetView: InstanceType<T>,
) => void,
): this;
delegate(
eventType: string,
selector: string,
listener: (this: this, e: Event & { originalEvent: Event }) => any,
): this;
delegate(eventType: any, selector: any, listener: any): this {
eventHelper.delegate(this, this._element, eventType, selector, listener);
): this {
eventHelper.delegate(this, this.element(), eventType, selector, listener);
return this;
}

/* eslint-enable @typescript-eslint/no-explicit-any */

private _createEvent<
private _createCustomEvent<
T extends new (...args: any[]) => Event,
U extends CustomEventInitFromClass<T>,
>(EventClass: T, options: U): InstanceType<T> {
Expand All @@ -188,15 +125,11 @@ export abstract class Base {
event: T,
eventInitDict: U,
): this;
dispatchEvent<T extends new (...args: any[]) => Event, U extends CustomEventInitFromClass<T>>(
event: Event | T,
eventInitDict?: U,
): this {
if (event instanceof Event) {
this.element().dispatchEvent(event);
} else {
this.element().dispatchEvent(this._createEvent(event, eventInitDict!));
}
dispatchEvent(event: any, eventInitDict?: any): this {
const el = this.element();
el.dispatchEvent(
event instanceof Event ? event : this._createCustomEvent(event, eventInitDict),
);
return this;
}

Expand Down