fix: refresh relative timestamps after midnight by agent-p1p · Pull Request #481 · marmot-protocol/whitenoise-mac

agent-p1p · 2026-07-12T03:52:11Z

Fixes #470

Summary

Refreshes chat and message relative timestamp labels on NSCalendarDayChanged.
Refreshes after returning to the foreground when a day boundary was crossed while inactive.
Keeps date formatting out of ordinary chat/message row renders by preserving equatable row boundaries.
Makes timestamp formatting honor an injected reference date and adds a midnight regression test.

Verification

git diff --check — passed.
Conflict-marker and post-rebase semantic sweeps — passed.
Superseded PR fix: refresh relative timestamps after midnight #477 proved this change compiles, passes static analysis, passes strict Swift format after correction, and its new regression test passes.
fix: refresh relative timestamps after midnight #477's remaining failures reproduce on master in media-cache tests outside this diff. This PR is stacked on the green stabilization PR fix: stabilize media cache CI tests #464 so its own CI can run against the corrected test harness.
Local macOS build/tests unavailable on this Linux worker (xcodebuild and swift are absent).

Stack

Base: fix: stabilize media cache CI tests #464 (pip/whitenoise-mac-457-v2)
After fix: stabilize media cache CI tests #464 merges, retarget this PR to master; the Bug: precomputed relative timestamp labels (ChatItem.timestampLabel / MessageItem.timeLabel) never refresh across a day boundary, so "today" times stay stale after midnight #470 diff is limited to the six files shown here.

Sensitive paths

None.

Summary by CodeRabbit

Bug Fixes
- Improved message and conversation timestamp accuracy when the calendar day changes.
- Timestamps now refresh when the app becomes active again.
- Updated timestamp formatting to respect the current locale and reference date.
- Ensured edited-message labels and date details update consistently across conversations, timelines, and the sidebar.
Tests
- Added coverage for timestamp updates across calendar days and refreshed label formatting.

Refresh chat and message timestamp projections when the calendar day changes or the app returns to the foreground. Keep formatting outside ordinary row renders and cover the day-boundary transition with a regression test. Fixes #470

coderabbitai · 2026-07-12T03:52:19Z

Walkthrough

ChatItem and MessageItem now compute timestamp labels using explicit dates and locales. SwiftUI views receive a shared timestamp reference date, refreshed on calendar-day changes and app activation, while tests cover formatting across day boundaries.

Changes

Timestamp refresh

Layer / File(s)	Summary
Timestamp reference-date environment `whitenoise-mac/ContentView.swift`	Adds an environment timestamp reference date and refreshes it on calendar-day changes and app activation.
Model timestamp computation `whitenoise-mac/Models/MessengerModels.swift`	Removes stored rendered labels, adds parameterized formatting methods, updates equality, and uses explicit same-day checks.
Timestamp view propagation `whitenoise-mac/Views/MessageMediaViews.swift`, `whitenoise-mac/Views/MessengerShellView.swift`, `whitenoise-mac/Views/SidebarViews.swift`	Passes timestamp date and locale through conversation views and computes sidebar, bubble, and timeline labels during rendering.
Timestamp refresh validation `whitenoise-macTests/whitenoise_macTests.swift`	Updates row fixtures and assertions and adds day-boundary timestamp formatting coverage.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

marmot-protocol/whitenoise-mac#217: Previously introduced precomputed ChatItem.timestampLabel behavior that this change replaces.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR addresses `#470` by re-deriving stale timestamp labels on day changes and foregrounding, while preserving row diffing and adding regression coverage.
Out of Scope Changes check	✅ Passed	The changes stay focused on timestamp refresh and formatting updates, with no obvious unrelated additions.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: refreshing stale relative timestamps after day rollover.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch pip/whitenoise-mac-470-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

stage-review · 2026-07-12T03:52:33Z

Ready to review this PR? Stage has broken it down into 6 individual chapters for you:

	Title
1	Enable dynamic reference dates in timestamp formatting
2	Refactor Messenger models to compute labels dynamically
3	Manage reference date state in ContentView
4	Wire reference date through message views
5	Wire reference date through sidebar views
6	Update tests and add midnight regression test

_{Chapters generated by Stage for commit efc1e5a on Jul 12, 2026 4:07am UTC.}

agent-p1p

Pip adversarial review

Verdict: APPROVE — no blocking findings. Submitted as a comment because agent-p1p cannot formally approve its own PR.

Blocking

None.

Suggestions

whitenoise-mac/Models/MessengerModels.swift:124-126, 177-180, 1578-1580, 1680-1700, 1817-1819 — the displayed chat/message labels now always come from the new (at:locale:) methods behind equatable view boundaries. The old stored timestampLabel, timeLabel, and metadataLabel projections are no longer read by production views, but are still computed and compared; their comments also still claim they are the render-time optimization. Consider removing this redundant state/equality work, or document the remaining non-view reason for retaining it. The current behavior is correct, but this leaves two competing label representations.
whitenoise-macTests/whitenoise_macTests.swift:3037 — strengthen the chat-row regression from != expectedTime to the exact expected weekday label. The next-day reference remains in the same week, so asserting the specific weekday branch would guard the sidebar behavior as precisely as the message assertion guards the abbreviated date-time branch.

Nitpicks

whitenoise-mac/Views/SidebarViews.swift:518-525 — ChatTimestampText's synthesized equality compares the entire ChatItem, although only updatedAt, referenceDate, and locale affect the formatted label. A narrower input/key would express the invariant and avoid reformatting when unrelated chat fields change.
whitenoise-mac/Views/MessageMediaViews.swift:78-79 — the default Date()/locale inputs are unnecessary at the production call site and can silently create a fresh equality key for future callers. Requiring explicit inputs would make the daily refresh contract clearer.

Verification

Reviewed the six-file diff at a4289d2ebda5f12b7eb52d704632a0bf29a58b5b against stacked base pip/whitenoise-mac-457-v2.
git diff --check passes.
GitHub Mac CI is green: strict Swift format, project sanity, 421 tests across two suites, and release arm64 smoke build.
Static Analysis is green.
The NSCalendarDayChanged path covers an active app; the didBecomeActive same-day guard covers a day crossed while inactive. The reference date participates in both message-row and sidebar equatable inputs, so the labels actually invalidate at the boundary.
Sensitive paths touched: none.

Remove stale mapping-time labels, narrow the sidebar's equatable timestamp inputs, require explicit message-row clock inputs, and assert the exact weekday transition in the regression test.

agent-p1p · 2026-07-12T04:13:31Z

@coderabbitai review

coderabbitai · 2026-07-12T04:13:36Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

agent-p1p · 2026-07-12T04:36:24Z

@coderabbitai review

coderabbitai · 2026-07-12T04:36:29Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

agent-p1p · 2026-07-12T04:41:54Z

Addressed the adversarial review suggestions in efc1e5a:

removed the redundant mapping-time chat/message timestamp labels and equality work
narrowed ChatTimestampText to its actual updatedAt input
required explicit message-row reference date and locale inputs
strengthened the regression to assert the exact weekday label

Mac CI and static analysis pass. The fresh CodeRabbit review generated no actionable comments.

agent-p1p added 2 commits July 12, 2026 05:51

fix: refresh relative timestamps after midnight

3d52f18

Refresh chat and message timestamp projections when the calendar day changes or the app returns to the foreground. Keep formatting outside ordinary row renders and cover the day-boundary transition with a regression test. Fixes #470

style: align timestamp view modifiers

a4289d2

agent-p1p commented Jul 12, 2026

View reviewed changes

refactor: simplify timestamp refresh state

efc1e5a

Remove stale mapping-time labels, narrow the sidebar's equatable timestamp inputs, require explicit message-row clock inputs, and assert the exact weekday transition in the regression test.

agent-p1p marked this pull request as ready for review July 12, 2026 04:41

mubarakcoded merged commit bf28027 into pip/whitenoise-mac-457-v2 Jul 13, 2026
3 checks passed

mubarakcoded deleted the pip/whitenoise-mac-470-v2 branch July 13, 2026 11:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: refresh relative timestamps after midnight#481

fix: refresh relative timestamps after midnight#481
mubarakcoded merged 3 commits into
pip/whitenoise-mac-457-v2from
pip/whitenoise-mac-470-v2

agent-p1p commented Jul 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 12, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

stage-review Bot commented Jul 12, 2026 •

edited

Loading

Uh oh!

agent-p1p left a comment

Uh oh!

agent-p1p commented Jul 12, 2026

Uh oh!

coderabbitai Bot commented Jul 12, 2026 •

edited

Loading

Uh oh!

agent-p1p commented Jul 12, 2026

Uh oh!

coderabbitai Bot commented Jul 12, 2026 •

edited

Loading

Uh oh!

agent-p1p commented Jul 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

agent-p1p commented Jul 12, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Stack

Sensitive paths

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

stage-review Bot commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agent-p1p left a comment

Choose a reason for hiding this comment

Pip adversarial review

Blocking

Suggestions

Nitpicks

Verification

Uh oh!

agent-p1p commented Jul 12, 2026

Uh oh!

coderabbitai Bot commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agent-p1p commented Jul 12, 2026

Uh oh!

coderabbitai Bot commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agent-p1p commented Jul 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

agent-p1p commented Jul 12, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 12, 2026 •

edited

Loading

stage-review Bot commented Jul 12, 2026 •

edited

Loading

coderabbitai Bot commented Jul 12, 2026 •

edited

Loading

coderabbitai Bot commented Jul 12, 2026 •

edited

Loading