fix: defer composer height measurements#474
Conversation
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Ready to review this PR? Stage has broken it down into 1 individual chapter for you:
Chapters generated by Stage for commit 8edcd5e on Jul 13, 2026 12:41pm UTC. |
Adversarial reviewVerdict: implementation is correct; no code changes requested. Merge remains blocked by red CI. Code review
Blocking — workflow / CIThe PR's This is demonstrably pre-existing and unrelated to this SwiftUI-only diff: the same test and same three assertions fail on base commit Existing issue #457 tracks the broken baseline test. No scope expansion is requested here, but Pip policy forbids merging any PR that has had red CI, so this remains a workflow blocker for #474. Verification
Counts: 1 blocking workflow finding, 0 code blockers, 0 suggestions, 0 nitpicks. |
Fixes #469
Summary
makeNSViewreturnsupdateNSViewand retain its deferred measurementtextDidChange, which runs from the AppKit delegate event rather than SwiftUI's representable update transactionVerification
git diff --check— passedmakeNSViewandupdateNSViewcontain exactly one deferred measurement and no synchronous binding writescripts/ci/macos-sanity-checks.sh— unavailable on this Linux host (xcodebuild: command not found)xcrun swift-format lint --configuration .swift-format --recursive --parallel --strict whitenoise-mac whitenoise-macTests whitenoise-macUITests— unavailable on this Linux host (xcrun: command not found)xcodebuild: command not found)No regression test was added: this bug is specifically SwiftUI/AppKit lifecycle scheduling, and a meaningful behavior test requires macOS execution. A source-scrape test or test-only visibility hook would be more brittle and complex than the two-call fix. CI will run the native checks.
Sensitive paths
None.