refactor: simplify archived chat metadata preservation

[agent-p1p]

Summary

• collapse identical moveChatToArchived branches into one unconditional metadata-preservation path
• remove the now-unused shouldEnrich helper parameter
• preserve existing behavior: archived rows retain resolved metadata before optional enrichment

Verification

• git diff --check
• source regression assertions for the simplified call/signature/branch
• macOS xcodebuild and swift-format unavailable on this Linux worker; GitHub Mac CI will run the native checks

Fixes #472

---

Summary by CodeRabbit

• Bug Fixes
  • Improved chat archiving to preserve resolved chat details when moving an active chat to the archive.
  • Ensured archived chat rows consistently retain their available metadata.

[stage-review]

Ready to review this PR? Stage has broken it down into 2 individual chapters for you:

	Title
1	Simplify moveChatToArchived signature and metadata preservation
2	Update call site for archived chat movement

_{Chapters generated by Stage for commit bb4b9f8 on Jul 12, 2026 3:33am UTC.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b7089f7c-3e04-4ab9-a9b4-2f517af93f03

📥 Commits

Reviewing files that changed from the base of the PR and between 0454dbf and bb4b9f8.

📒 Files selected for processing (1)

• whitenoise-mac/Core/WorkspaceState+ChatList.swift

---

Walkthrough

Changes

Archived chat metadata

Layer / File(s)	Summary
Archived chat move behavior whitenoise-mac/Core/WorkspaceState+ChatList.swift	The archived-row path stops passing shouldEnrich; moveChatToArchived now preserves resolved metadata from the current active chat whenever available.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change to archived chat metadata preservation.
Linked Issues check	✅ Passed	The change removes the dead shouldEnrich branch and collapses moveChatToArchived to the unconditional metadata-preservation path requested in #472.
Out of Scope Changes check	✅ Passed	The diff appears narrowly scoped to the archived chat metadata refactor and does not introduce unrelated changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch pip/whitenoise-mac-472

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[agent-p1p]

Pip adversarial review

BLOCKING:

• Mac CI is red; this PR cannot be merged under the ever-red policy. The PR Checks job failed on head bb4b9f846db2d85dd77e057e38630e8be4ebabf5 with five unit-test issues in messageMediaDiskCacheReadDeletionMaintainsTrackedFootprint() and workspaceCoalescesAndCachesSourceEpochZeroMediaReferenceResolution(): https://github.com/marmot-protocol/whitenoise-mac/actions/runs/29178414181/job/86611725631. These are known base-branch failures tracked by CI: restore the macOS PR test plan after media-cache changes #457, not defects in this one-file refactor, but repository policy is explicit: a PR that has ever had red CI must not merge. Retire this PR and recreate it after CI: restore the macOS PR test plan after media-cache changes #457 restores a green base.

SUGGESTION:

• none

NITPICK:

• none

SUMMARY: The code change itself is correct and behavior-preserving: the original branches were identical, metadata preservation remains unconditional, the sole call site was updated, and the unused helper parameter is gone. git diff --check, static analysis, CodeRabbit, and independent source-regression assertions pass. The failed native unit-test run is nevertheless a merge blocker under the ever-red policy; the failures match the existing #457 incident on master.

VERDICT: REQUEST_CHANGES

SENSITIVE_PATHS: none

[agent-p1p]

Closing under the repository's ever-red policy. The code review passed, but this PR's PR Checks run failed on the known base-branch media-test incident tracked by #457.

Replacement plan: after #464 merges and master is green, rebase pip/whitenoise-mac-472, recreate a fresh draft PR, and require a clean first CI run.