Skip to content

fix: keep selected archived chat on live delta#456

Draft
agent-p1p wants to merge 1 commit into
masterfrom
pip/whitenoise-mac-450
Draft

fix: keep selected archived chat on live delta#456
agent-p1p wants to merge 1 commit into
masterfrom
pip/whitenoise-mac-450

Conversation

@agent-p1p

@agent-p1p agent-p1p commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • distinguish genuine active-to-archived transitions from steady-state archived-row deltas
  • keep an already-archived conversation selected while refreshing its preview/read-state fields
  • preserve existing auto-reselection when the selected chat actually leaves the active list

Test plan

  • added a regression test covering both the initial archive transition and a later live delta while the archived chat is selected
  • git diff --check
  • macOS unit/build checks deferred to GitHub Actions (xcodebuild is unavailable on this Linux worker)

Fixes #450


Open in Stage

Only run active-conversation teardown when an archived row actually transitions out of the active list. Steady-state archived updates now refresh the row without changing selection.

Fixes #450
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@agent-p1p, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 50 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8a3a11cb-6f6f-42db-b235-449cb6a7a509

📥 Commits

Reviewing files that changed from the base of the PR and between 0454dbf and aaa8962.

📒 Files selected for processing (2)
  • whitenoise-mac/Core/WorkspaceState+ChatList.swift
  • whitenoise-macTests/whitenoise_macTests.swift
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pip/whitenoise-mac-450

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@stage-review

stage-review Bot commented Jul 10, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 2 individual chapters for you:

Title
1 Distinguish active-to-archived transitions from archived deltas
2 Add regression test for archived chat selection
Open in Stage

Chapters generated by Stage for commit aaa8962 on Jul 10, 2026 2:44pm UTC.

@agent-p1p

Copy link
Copy Markdown
Contributor Author

CI note: this PR’s regression test passed in the macOS run:

  • archivedChatDeltaKeepsAlreadyArchivedSelection() passed
  • Swift format, project sanity checks, and Static Analysis passed

The aggregate PR Checks job is red only because messageMediaDiskCacheReadDeletionMaintainsTrackedFootprint() fails identically on current master at base SHA 0454dbf0 (master run: https://github.com/marmot-protocol/whitenoise-mac/actions/runs/29100021269). The unrelated CI break is tracked in #457. This PR does not touch the media-cache implementation or that test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant