Skip to content

Make chat notification state atomic#1508

Merged
mubarakcoded merged 3 commits into
masterfrom
sweep/1500-1505-state-security
Jul 17, 2026
Merged

Make chat notification state atomic#1508
mubarakcoded merged 3 commits into
masterfrom
sweep/1500-1505-state-security

Conversation

@mubarakcoded

@mubarakcoded mubarakcoded commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace parallel mute flows with one immutable notification state and derived muted-key projection
  • serialize state publication and preference persistence to prevent lost concurrent updates
  • compare notification tap capability tokens with MessageDigest.isEqual
  • update consumers and add regression coverage for both invariants

Verification

  • git diff --check
  • Local Gradle tests intentionally not run for this fast sweep; CI will validate the branch.

Closes #1500
Closes #1505


Open in Stage

@stage-review

stage-review Bot commented Jul 17, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 4 individual chapters for you:

Title
1 Secure notification tap token validation
2 Unify chat notification state and serialization
3 Update UI consumers for atomic state
4 Verify atomic state and concurrency
Open in Stage

Chapters generated by Stage for commit 6dbdc6e on Jul 17, 2026 12:02pm UTC.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b9f25f51-f26e-49dd-86b4-514e2d3659b0

📥 Commits

Reviewing files that changed from the base of the PR and between 13c6751 and 6dbdc6e.

📒 Files selected for processing (6)
  • app/src/main/java/dev/ipf/whitenoise/android/notifications/NotificationTapTokens.kt
  • app/src/main/java/dev/ipf/whitenoise/android/state/ChatMutePreferences.kt
  • app/src/main/java/dev/ipf/whitenoise/android/ui/chats/ChatsScreen.kt
  • app/src/main/java/dev/ipf/whitenoise/android/ui/group/GroupDetailsScreen.kt
  • app/src/test/java/dev/ipf/whitenoise/android/notifications/NotificationTapTokensTest.kt
  • app/src/test/java/dev/ipf/whitenoise/android/state/ChatMutePreferencesTest.kt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sweep/1500-1505-state-security

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

Preview APK for PR #1508

Home-screen label: 1508 White Noise with the blueprint launcher icon — installs side-by-side with the production and staging apps.

Install directly — one tap, no GitHub sign-in (public, content-addressed .apk). ARM64 only.

Every push to this PR rebuilds and updates this comment.

@mubarakcoded
mubarakcoded merged commit 8b6e989 into master Jul 17, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant