Skip to content

fix(openclaw): declare plugin workspace package#880

Open
agent-p1p wants to merge 1 commit into
masterfrom
pip/mdk-879
Open

fix(openclaw): declare plugin workspace package#880
agent-p1p wants to merge 1 commit into
masterfrom
pip/mdk-879

Conversation

@agent-p1p

@agent-p1p agent-p1p commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Fixes #879

Summary

  • declare the OpenClaw plugin root as the pnpm workspace package
  • retain the existing dependency build allowlist unchanged
  • restore the documented plain pnpm typecheck and pnpm test commands under pnpm 9

Verification

  • pnpm install --frozen-lockfile (pnpm 9.15.9)
  • pnpm typecheck (pnpm 9.15.9)
  • pnpm test (pnpm 9.15.9; 196 passed, 1 connector E2E skipped)
  • just openclaw-dev-test (pnpm 9.15.9)
  • pnpm install --frozen-lockfile && pnpm build (pnpm 10.13.1; matches the release workflow)

Sensitive paths

None.


Open in Stage

Summary by CodeRabbit

  • Chores
    • Updated workspace configuration to recognize the current project directory.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The pnpm workspace configuration now includes the current directory in its packages entry.

Changes

Workspace configuration

Layer / File(s) Summary
Declare the root package
integrations/openclaw/marmot/pnpm-workspace.yaml
Adds packages: ['.'] to include the plugin root in the pnpm workspace.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR adds the missing workspace package entry required by issue #879 and preserves the intended minimal fix.
Out of Scope Changes check ✅ Passed No out-of-scope changes are evident; the diff is limited to the workspace package declaration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: declaring the OpenClaw plugin as a pnpm workspace package.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pip/mdk-879

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@stage-review

stage-review Bot commented Jul 15, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 1 individual chapter for you:

Title
1 Declare OpenClaw plugin as workspace package
Open in Stage

Chapters generated by Stage for commit 01d3119 on Jul 15, 2026 9:21pm UTC.

@agent-p1p

Copy link
Copy Markdown
Contributor Author

Pip adversarial review — pass

Head reviewed: 01d3119b2d027780d582c17042cb92d871a721a2
Verdict: 0 blocking, 0 suggestions, 0 nitpicks.

The two-line workspace declaration is the smallest direct fix for #879. It preserves the existing allowBuilds policy and makes the documented root scripts runnable under pnpm 9 without touching the lockfile or unrelated code.

Independent verification:

  • npx --yes pnpm@9.15.9 typecheck — passed
  • npx --yes pnpm@9.15.9 test — passed: 196 tests; 1 connector E2E skipped
  • npx --yes pnpm@10.13.1 build — passed
  • git diff --check origin/master...HEAD — passed
  • git verify-commit HEAD — good ED25519 signature for agent-p1p
  • Worktree remained clean after verification

No sensitive paths are touched.

Filed follow-up #881 for the stale OpenClaw SDK version in the README; it predates and is out of scope for #879.

Full CI was still running at review time; the merge gate must evaluate its final state.

— Pip adversarial reviewer

@agent-p1p

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@agent-p1p
agent-p1p marked this pull request as ready for review July 15, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenClaw pnpm commands fail because workspace has no packages entry

1 participant