fix(agent): preserve stream parent relationship#878
Conversation
Thread the triggering prompt message ID through stream_begin and emit it on kind-1200 start events. Keep the field optional for existing callers and wire clients. Fixes #876
|
Warning Review limit reached
Next review available in: 21 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (18)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Ready to review this PR? Stage has broken it down into 7 individual chapters for you: Chapters generated by Stage for commit 79e6791 on Jul 15, 2026 8:54pm UTC. |
agent-p1p
left a comment
There was a problem hiding this comment.
Adversarial review at exact head 79e67911290d40f73a5585a522a2006532bf4cbe.
BLOCKING:
- none
SUGGESTION:
- none
NITPICK:
- none
SUMMARY: The change is well-scoped and completes the durable chain final --stream-start--> start --parent--> triggering prompt. The optional control-protocol field remains wire-compatible when omitted; the connector and app intent enforce a 32-byte message ID before emitting the kind-1200 parent tag; Hermes copies the inbound inner-event ID into the spawned task context used by draft streaming; and OpenClaw passes the same inbound messageIdHex already used by its durable reply path. The connector projection test verifies the emitted tag, and both host integrations cover populated and omitted propagation. No correctness, security/privacy, or unnecessary-complexity blocker found.
Verification:
cargo test -p agent-control— 13 passedcargo test -p agent-connector connector_socket_composes_and_finalizes_stream— 1 passedcargo test -p marmot-app stream_start_intent_— 4 passedpython3 -m unittest discover -s integrations/hermes/marmot/tests— 88 passed- OpenClaw typecheck — passed
- OpenClaw Vitest — 198 passed, 1 skipped
- GitHub CI — all required jobs green
Follow-up: filed #879 for the pre-existing pnpm-workspace.yaml configuration that makes plain pnpm typecheck / pnpm test fail. It is unrelated to #876; the scripts pass with --ignore-workspace.
VERDICT: APPROVE. This is an approve-equivalent COMMENTED review because agent-p1p authored the PR and cannot formally approve its own PR.
SENSITIVE_PATHS: crates/agent-control/** and crates/agent-connector/** are sensitive under the repository rubric. Recorded for the merge gate; not a review blocker.
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
parent_message_id_hextostream_beginwhile preserving omitted-field wire compatibilityVerification
just fast-cicargo test -p agent-controlcargo test -p agent-connectorcargo test -p marmot-apppython3 -m unittest discover -s integrations/hermes/marmot/testsFixes #876