fix(hermes/marmot): accept is_reconnect kwarg in connect()

[jooray]

Fixes #836.

hermes-agent connects platform adapters via await adapter.connect(is_reconnect=...), and the base adapter plus the bundled SimpleX plugin both use the keyword-only signature async def connect(self, *, is_reconnect: bool = False) -> bool. The Marmot adapter's override was async def connect(self), so every connect raised:

✗ marmot error: MarmotPlatformAdapter.connect() got an unexpected keyword argument 'is_reconnect'

and the platform never came up (no socket opened to wn-agent).

This widens the signature to match; the body doesn't need the argument. One line.

Verified on a live deployment: after this change the adapter connects and the platform reaches connected.

---

Summary by CodeRabbit

• Refactor
  • Updated the connection interface to support reconnect scenarios via an optional keyword parameter.
  • Existing connection behavior remains unchanged.
  • Added/expanded adapter tests to verify the new reconnect keyword is accepted and returns expected results for both cold start and reconnect.

[stage-review]

Ready to review this PR? Stage has broken it down into 2 individual chapters for you:

	Title
1	Update Marmot adapter connect signature
2	Verify connect signature in tests

_{Chapters generated by Stage for commit 9b8a06d on Jul 17, 2026 2:20am UTC.}

[coderabbitai]

Warning

Review limit reached

@jgmontoya, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6b206c93-20f3-4c7f-993f-5683e9ef74ad

📥 Commits

Reviewing files that changed from the base of the PR and between 8726d80 and 9b8a06d.

📒 Files selected for processing (2)

• integrations/hermes/marmot/adapter.py
• integrations/hermes/marmot/tests/test_adapter.py

Walkthrough

The Marmot adapter’s connect method now accepts the keyword-only is_reconnect flag. Test shims and coverage verify successful cold and reconnect calls, listener-task creation, and cleanup.

Changes

Marmot connection compatibility

Layer / File(s)	Summary
Update Marmot connect signature and validation integrations/hermes/marmot/adapter.py, integrations/hermes/marmot/tests/test_adapter.py	MarmotPlatformAdapter.connect accepts the optional keyword-only reconnect flag, while tests cover both flag values and verify connection state and listener cleanup.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: accepting the is_reconnect kwarg in MarmotPlatformAdapter.connect().
Linked Issues check	✅ Passed	The PR matches issue #836 by widening connect() to accept is_reconnect and adding a test for the contract.
Out of Scope Changes check	✅ Passed	The added test support is directly related to the connect() signature fix and no unrelated changes are apparent.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}