Skip to content

wn: depend on openssl@3 and pkgconf so it builds on Linux#2

Merged
erskingardner merged 1 commit into
masterfrom
claude/wn-openssl-linux
Jul 6, 2026
Merged

wn: depend on openssl@3 and pkgconf so it builds on Linux#2
erskingardner merged 1 commit into
masterfrom
claude/wn-openssl-linux

Conversation

@erskingardner

@erskingardner erskingardner commented Jul 6, 2026

Copy link
Copy Markdown
Member

Follow-up to #1. The Linux leg of tap CI failed to build wn 0.9.1:

error: failed to run custom build command for `openssl-sys v0.9.115`
Could not find directory of OpenSSL installation
error: failed to compile `wn-cli v0.9.1`

Root cause

openssl-sys is a transitive dependency via rusqlitelibsqlite3-sys (SQLCipher-encrypted SQLite, the storage layer). It links against system OpenSSL. macOS build environments supply OpenSSL implicitly — the macOS legs and local builds passed — but the minimal ghcr.io/homebrew/brew:main Linux container does not, so the build script bailed. TLS already uses rustls; this is purely the SQLite encryption layer, so the native dep is genuinely required rather than removable.

Fix

  • depends_on "openssl@3" — provides libcrypto for openssl-sys
  • depends_on "pkgconf" => :build — lets the build script locate it

Passes brew style and brew audit --strict locally.

🤖 Generated with Claude Code


Open in Stage

The dependency tree pulls openssl-sys via rusqlite's SQLCipher (encrypted
SQLite) storage layer. macOS build environments supply OpenSSL implicitly,
so the formula built there, but the minimal Homebrew Linux container does
not, and `cargo install` failed in openssl-sys's build script.

Declare openssl@3 as a link dependency and pkgconf as a build dependency
so the build script can locate the crypto lib on every platform.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@cursor

cursor Bot commented Jul 6, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 50 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c88cce20-6757-49e9-bebb-3b8e100310e1

📥 Commits

Reviewing files that changed from the base of the PR and between 67f8f78 and 2c42c7b.

📒 Files selected for processing (1)
  • Formula/wn.rb
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/wn-openssl-linux

Comment @coderabbitai help to get the list of available commands.

@stage-review

stage-review Bot commented Jul 6, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 1 individual chapter for you:

Title
1 Add OpenSSL and pkgconf dependencies for Linux builds
Open in Stage

Chapters generated by Stage for commit 2c42c7b on Jul 6, 2026 12:48pm UTC.

@erskingardner
erskingardner merged commit 26c4702 into master Jul 6, 2026
4 checks passed
@erskingardner
erskingardner deleted the claude/wn-openssl-linux branch July 6, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant