Repository navigation
Conversation
Long-press a video in the network browser to delete it after confirmation. Adds deleteFile to NetworkClient with WebDAV, SMB and FTP implementations. Closes marlboro-advance#842
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #842.
Long-press a video in the network browser → the existing delete confirmation dialog → the file is deleted on the server and removed from the list. Failures show a toast.
NetworkClient.deleteFile(path)with implementations for WebDAV (sardine.delete), SMB (DiskShare.rm) and FTP (FTPClient.deleteFile)NetworkRepository.deleteFile; the client lookup shared withlistFilesis pulled intogetOrCreateClientlistFilesintotoRelativePathso delete resolves paths the same way (no behaviour change)Tested on a Pixel 9 (debug build) against a WebDAV server: long-press → confirm deletes the file on the server. SMB and FTP are not tested on a device.