Skip to content

perf: refactor states to be able to parse multiple characters #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DylanPiercey merged 2 commits into from
Jun 11, 2026
Merged

perf: refactor states to be able to parse multiple characters #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dd04ad
perf: refactor states to be able to parse multiple characters
DylanPiercey Jun 11, 2026
c9c2baf
chore: improve test coverage
DylanPiercey Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .c8rc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"include": ["src/**"],
"exclude": ["src/**/__tests__/**"],
"reporter": ["text", "lcov"]
}
5 changes: 5 additions & 0 deletions .changeset/petite-signs-dance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"htmljs-parser": patch
---

Refactor parser to allow individual states to process multiple characters. This allows for eager scanning, simplifies things some, and improves performance by about 30% in realworld tempaltes.

@coderabbitai coderabbitai Bot Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix typos in the changeset description.

The release note has spelling issues (realworld, tempaltes) that should be corrected before publish.

✏️ Proposed fix 
-Refactor parser to allow individual states to process multiple characters. This allows for eager scanning, simplifies things some, and improves performance by about 30% in realworld tempaltes.
+Refactor parser to allow individual states to process multiple characters. This allows for eager scanning, simplifies things some, and improves performance by about 30% in real-world templates.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Refactor parser to allow individual states to process multiple characters. This allows for eager scanning, simplifies things some, and improves performance by about 30% in realworld tempaltes.
Refactor parser to allow individual states to process multiple characters. This allows for eager scanning, simplifies things some, and improves performance by about 30% in real-world templates.
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.changeset/petite-signs-dance.md at line 5, Fix typos and small phrasing in
the changeset sentence that begins "Refactor parser to allow individual states
to process multiple characters." Replace "realworld" with "real-world", correct
"tempaltes" to "templates", and change "simplifies things some" to "simplifies
things somewhat" (or "simplifies things a bit") so the release note reads
clearly and correctly.

Loading
Loading