fix: do not add a newline to an empty code block - #4073
Open
Kjubikstronk wants to merge 1 commit into
Open
Conversation
Renderer.code appended a newline unconditionally, so a code block with no content rendered as <pre><code>\n</code></pre> instead of <pre><code></code></pre>. This fixes CommonMark examples 126, 130, 144 and 237. The spec suite did not catch it because htmlIsEqual leaves html-differ's ignoreWhitespaces at its default of true, and whitespace inside pre/code is significant, so all four were already reported as passing.
|
@Kjubikstronk is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version: 18.0.11 (53cb13f)
Markdown flavor: CommonMark
Description
Renderer.codeappends a newline unconditionally:For a code block with no content that turns
''into'\n', so an empty fence renders as<pre><code>\n</code></pre>instead of<pre><code></code></pre>.The lexer is not involved.
new Lexer({gfm: false}).lex('```\n')already givestext: ''.Expectation