-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix: Fix backtick and code rendering in links #3783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6ac963e
test: add new test cases for handling backticks in links
basilaiman 691396a
test: REDOS tests for for handling backticks in links
basilaiman 1be47b3
fix: improve regex for inline label handling to support nested backticks
basilaiman 0ba5022
test: update backticks in link label redos test according to commonma…
basilaiman b3c4f58
fix: update regex for inline label handling to correctly match backticks
basilaiman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| <p><a href="https://example.com"><code>this is a backtick ` and it breaks stuff</code></a></p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| [`` this is a backtick ` and it breaks stuff ``](https://example.com) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| <p><a href="https://example.com"><code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code> a <code>a</code></a></p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| [` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a ` a `](https://example.com) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| <p><a href="https://example.com">``````````````````````````````````````````````````````````````````````````````````````````````````</a></p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| [``````````````````````````````````````````````````````````````````````````````````````````````````](https://example.com) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.