Skip to content

fix: handle backticks in link text for emphasis processing #3779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sajdakabir wants to merge 10 commits into from
Closed

fix: handle backticks in link text for emphasis processing #3779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2e073a9
fix: handle backticks in link text for emphasis processing
sajdakabir Oct 3, 2025
6842940
feat: test files
sajdakabir Oct 3, 2025
f246c14
refc: accept reviewer suggestion
sajdakabir Oct 3, 2025
4b5cd95
fix: improve regex for block skipping in emphasis processing
sajdakabir Oct 5, 2025
b20cb9d
chore: remove whitespace
sajdakabir Oct 7, 2025
6b96546
Merge branch 'master' of github.com-personal:sajdakabir/marked into f…
sajdakabir Oct 7, 2025
35cc17b
refc: remove indentations
sajdakabir Oct 7, 2025
b2b29a5
fix: correct link formatting in bold codespan edge case tests
sajdakabir Oct 8, 2025
f919bb5
Merge branch 'fix-blockskip-backtick-issue-3777' of github.com:sajdak…
sajdakabir Oct 8, 2025
4504904
refc: undo the last fix and remove the second paragraph
sajdakabir Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ const _punctuationOrSpaceGfmStrongEm = /(?!~)[\s\p{P}\p{S}]/u;
const _notPunctuationOrSpaceGfmStrongEm = /(?:[^\s\p{P}\p{S}]|~)/u;

// sequences em should skip over [title](link), `code`, <html>
const blockSkip = /\[(?:[^\[\]`]|`[^`]*?`)*?\]\((?:\\[\s\S]|[^\\\(\)]|\((?:\\[\s\S]|[^\\\(\)])*\))*\)|`[^`]*?`|<(?! )[^<>]*?>/g;
const blockSkip = /\[(?:[^\[\]`]|`(?:[^`\\]|\\.)*`)*?\]\((?:\\[\s\S]|[^\\\(\)]|\((?:\\[\s\S]|[^\\\(\)])*\))*\)|`[^`]*?`|<(?! )[^<>]*?>/g;

const emStrongLDelimCore = /^(?:\*+(?:((?!\*)punct)|[^\s*]))|^_+(?:((?!_)punct)|([^\s_]))/;

Expand Down
1 change: 1 addition & 0 deletions test/specs/new/bold_codespan_autolink.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<p><strong>Really weird edge case: bold around what looks like it might be a link, but is actually a link-looking thing with a code specifier in. [Like <code>this](https://github.com)</code>. It&#39;s now impossible to close the bold</strong>.</p>
1 change: 1 addition & 0 deletions test/specs/new/bold_codespan_autolink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
**Really weird edge case: bold around what looks like it might be a link, but is actually a link-looking thing with a code specifier in. [Like `this](https://github.com)`. It's now impossible to close the bold**.