Repository navigation
deps: lag-integration-tests takes @mark1russell7/otel-ts ^0.1.2 from npm - #65
Merged
Merged
Conversation
experiments pinned otel-ts 92cd393, and lag-integration-tests took the unpinned github: ref. Both now use the npm release 0.1.2 (dist built from source by otel-ts's release.yml), so otel-ts can stop committing dist/. The lockfile changes only the otel-ts entries (pnpm install --lockfile-only, then the format-only lines pnpm 10.34.7 adds to other entries, libc and gitHosted, put back): no other dependency moves. The 0.1.2 snapshot uses entries that the lockfile already has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
E8 measures the context managers of otel-ts as they were at 92cd393: its main entry took contextManager "zone", and setup D relies on that entry loading zone.js. otel-ts 0.1.2 gives each context its own entry (#6), so CI failed: Type '"zone"' is not assignable to type 'ContextManagerOption' (setups/b-zone.ts). A move to 0.1.2 changes what E8 measures, so it is not a dependency bump. The pin stays installable after otel-ts drops dist/ from git: the tarball of a commit keeps the dist/ that the commit had. Only the unpinned github: ref (lag-integration-tests) needed the move. The lockfile changes only the otel-ts entries of lag-integration-tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mark1russell7
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
packages/lag-integration-testsused the unpinnedgithub:mark1russell7/otel-ts. It now uses"@mark1russell7/otel-ts": "^0.1.2", the npm release, whosedist/is built from source by otel-ts'srelease.yml. After this merges, otel-ts can stop committingdist/(the release session's plan).Why experiment E8 keeps its pin
The first commit also moved
packages/experiments, and CI failed:Type '"zone"' is not assignable to type 'ContextManagerOption'ine8-async-context/page/setups/b-zone.ts.92cd393. At that commit, the main entry tookcontextManager: "zone", and setup D relies on that entry loading zone.js.dist/from git, because the tarball of a commit keeps thedist/that commit had. Only the unpinned reference needed to move.The lockfile
pnpm install --lockfile-only(pnpm 10.34.7, the repo'spackageManager). No full install.a291331becomes0.1.2).libc:on platform packages,gitHosted/integrityon thegithub:resolutions). I put those back as they were, and no other dependency moves. One run resolved thegithub:dependencies asgit+ssh://instead of codeload, which CI can't fetch, so I made the lockfile again frommain's.Both packages are private, so there's no changeset or release.
🤖 Generated with Claude Code