Repository navigation
Adopt the standard npm release of the template - #3
Merged
Merged
Conversation
- release.yml: a version bump merged to main (or workflow_dispatch) publishes each missing version with OIDC and provenance, from the template's verify/build/publish core. No environment, no registry-url, npm CLI only. - The GitHub release job stays. It runs when the publish job published ireko (its "published" output), or on a manual start, and it now makes the tag v<version>. - The CHANGELOG check moves from the old tag preflight into the build job, with pnpm size and the tarball smoke test. - scripts/release/: pack, bootstrap and audit from the template (ignored by oxlint). - RELEASING.md, CLAUDE.md and docs/REVIEW.md 10.1: the new release flow and the npm rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…plete-sanitization) The same fix as mark1russell7/template#3: replaceAll in npm-audit.mjs and npm-bootstrap.mjs, and ${name//\//%2f} in release.yml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… pnpm The same fix as mark1russell7/template#4: prepare/prepack output mixes into the stdout of pnpm pack --json, so JSON.parse failed (cue release run 39053834123). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves ireko onto the standard npm release of mark1russell7/template (
RELEASING.md).Trigger change. A pushed
v*tag no longer starts the release. A version bump merged tomainstarts it (the paths filter ispackage.jsonandpackages/*/package.json), and so doesworkflow_dispatch.Core (from the template, unchanged): verify (
ci.yml, which already hasworkflow_call) → build (pack all published packages withscripts/release/pack.mjs; onlyirekois non-private) → publish. The publish job holds onlyid-token: write, runs no repository code, uses the npm CLI, and sets noregistry-urland no environment. It skips versions already on npm and retries a 429.Extra steps kept:
main),pnpm size, and the smoke test of the tarball.github-releaseruns when the publish job's newpublishedoutput containsireko@<version>, or when the workflow is started by hand. It skips a release that exists, so a manual start finishes a half-done release. It now creates the tagv<version>itself (gh release create --target $GITHUB_SHA).npm trust (action for the owner at the next release). The old publish job ran in
environment: npm, so the trusted publisher of ireko probably names that environment. The standard names none. This repository has GitHub's immutable OIDC subject (repo:mark1russell7@39885340/ireko@1041854607), and npm refuses an environment-named trust for that subject (npm/cli#9969). 0.1.0 was a manual publish, so the trust was never validated and has probably expired (2-day window). At the next release, after the version bump is onmain, the owner runs:Draft: merge it only after render's first release proves the standard workflow.
🤖 Generated with Claude Code