fix(wallet): complete React 19 move and use the browser global (wxt 0.20 / TS6)#132
Merged
Merged
Conversation
….20 / TS6) The dependabot bumps left the wallet in a state that fails a fresh install: - #121 bumped react-dom + @types/react-dom to 19 but left react + @types/react at 18, an unbuildable mix (peer ERESOLVE; react 18 + react-dom 19). Aligned react and @types/react to ^19.2 so the whole popup is on React 19. - wxt 0.20 + TS6 no longer wire the global chrome value, so the five popup sites still using chrome.* now use the WXT-provided browser global (the rest of the wallet already does), including the Port type. browser.runtime.getURL is path-typed, so the expanded-tab URL gets a leading slash. - TS6 strictness: guard the approval window result (w?.id). 155 wallet tests pass; tsc clean; wxt build clean on react 19 + ts6 + wxt 0.20.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-through after merging the wallet dependabot bumps (#117 TS6, #121 react-dom, #122 wxt 0.20). On their own they left the wallet unable to install/build cleanly from scratch:
chromevalue, so the five popup sites still onchrome.*now use the WXT-providedbrowserglobal (the rest of the wallet already does), including thePorttype viaReturnType<typeof browser.runtime.connect>.browser.runtime.getURLis path-typed, so the expanded-tab URL gets a leading slash.w?.id).155 wallet tests pass; tsc clean; wxt build clean on React 19 + TS6 + wxt 0.20.