Skip to content

Device roles to capabilities - #197

Open
ajcraig wants to merge 27 commits into
pre-draftfrom
ajc/roles-to-capabilities
Open

Device roles to capabilities#197
ajcraig wants to merge 27 commits into
pre-draftfrom
ajc/roles-to-capabilities

Conversation

@ajcraig

@ajcraig ajcraig commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Description

This PR implements the approved strategy to remove device roles in lieu of device capabilities.

Issues Addressed

Implements approved SUP linked below:
margo/specification-enhancements#63

Change Type

Please select the relevant options:

  • Fix (change that resolves an issue)
  • New enhancement (change that adds specification content)
  • Content edits (change that edits existing content)

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established patterns, and best practices.

ajcraig added 2 commits July 14, 2026 16:04
Signed-off-by: Armand Craig <acraig@project.margo.org>
… files.

Signed-off-by: Armand Craig <acraig@project.margo.org>
@ajcraig ajcraig changed the title Ajc/roles to capabilities [DRAFT] Device roles to capabilities Jul 23, 2026
Additional edits are still warranted in the observability content regarding gateway devices(this will be handled outside this PR).

Signed-off-by: Armand Craig <acraig@project.margo.org>
@ajcraig
ajcraig marked this pull request as ready for review July 30, 2026 18:35
@ajcraig
ajcraig requested a review from a team as a code owner July 30, 2026 18:35
@ajcraig ajcraig changed the title [DRAFT] Device roles to capabilities Device roles to capabilities Jul 30, 2026
Comment thread system-design/specification/margo-devices/device-requirements.md Outdated
Comment thread system-design/specification/margo-devices/device-requirements.md Outdated
Comment thread system-design/specification/margo-devices/device-requirements.md Outdated
Comment thread system-design/specification/margo-devices/device-requirements.md Outdated
Comment thread system-design/specification/margo-devices/device-requirements.md Outdated
Comment thread system-design/specification/margo-management-interface/device-capabilities.md Outdated
Comment thread system-design/specification/margo-management-interface/device-capabilities.md Outdated
Comment thread system-design/specification/margo-management-interface/device-capabilities.md Outdated
ajcraig and others added 10 commits July 31, 2026 08:36
Co-authored-by: Philip Presson <philip.presson@us.abb.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
Co-authored-by: Philip Presson <philip.presson@us.abb.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
…capabilities.md

Co-authored-by: Philip Presson <philip.presson@us.abb.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
…observability-data.md

Co-authored-by: Philip Presson <philip.presson@us.abb.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
…observability-data.md

Co-authored-by: Philip Presson <philip.presson@us.abb.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
…capabilities.md

Co-authored-by: Philip Presson <philip.presson@us.abb.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
…capabilities.md

Co-authored-by: Philip Presson <philip.presson@us.abb.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
…capabilities.md

Co-authored-by: Philip Presson <philip.presson@us.abb.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
Signed-off-by: Armand Craig <acraig@project.margo.org>
…properties.

Signed-off-by: Armand Craig <acraig@project.margo.org>
@ajcraig
ajcraig requested review from matlec and phil-abb July 31, 2026 16:06
Signed-off-by: Armand Craig <acraig@project.margo.org>

@matlec matlec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to my comments in collecting-workload-observability-data.md: publishing-workload-observability-data.md also still refers to the removed device roles (standalone/cluster).

Comment thread system-design/specification/margo-devices/device-requirements.md Outdated
Comment thread system-design/specification/margo-devices/device-requirements.md Outdated
Comment thread system-design/specification/margo-devices/device-requirements.md Outdated
Comment thread system-design/specification/margo-devices/device-requirements.md Outdated
Comment thread system-design/specification/margo-management-interface/device-capabilities.md Outdated
Comment thread system-design/specification/margo-management-interface/device-capabilities.md Outdated
ajcraig and others added 6 commits August 3, 2026 09:44
…capabilities.md

Co-authored-by: Matthias Lechner <matlec.public@gmail.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
Co-authored-by: Matthias Lechner <matlec.public@gmail.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
Co-authored-by: Matthias Lechner <matlec.public@gmail.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
Co-authored-by: Matthias Lechner <matlec.public@gmail.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
Co-authored-by: Matthias Lechner <matlec.public@gmail.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
Co-authored-by: Matthias Lechner <matlec.public@gmail.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
ajcraig and others added 6 commits August 3, 2026 09:48
Co-authored-by: Matthias Lechner <matlec.public@gmail.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
Co-authored-by: Matthias Lechner <matlec.public@gmail.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
…capabilities.md

Co-authored-by: Matthias Lechner <matlec.public@gmail.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
…capabilities.md

Co-authored-by: Matthias Lechner <matlec.public@gmail.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
…capabilities.md

Co-authored-by: Matthias Lechner <matlec.public@gmail.com>
Signed-off-by: Armand Craig <acraig@project.margo.org>
…abilities

Signed-off-by: Armand Craig <acraig@project.margo.org>
@ajcraig
ajcraig force-pushed the ajc/roles-to-capabilities branch from d8e6745 to 00ab1b4 Compare August 3, 2026 17:54
@margo margo deleted a comment from github-actions Bot Aug 3, 2026
Signed-off-by: Armand Craig <acraig@project.margo.org>
@ajcraig

ajcraig commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@matlec give her another pass through. I've addressed the majority of your mentions in my latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants