chore: adds golang linting rules and fixes issues in the code - #234
Merged
Conversation
singhmj-1
requested review from
nitparihar,
sanjujunnuthula and
vireshnavalli
as code owners
April 1, 2026 17:42
singhmj-1
force-pushed
the
chore/fix-linting-issues
branch
2 times, most recently
from
April 3, 2026 03:00
7216c2c to
75fc8c9
Compare
sanjujunnuthula
approved these changes
Apr 3, 2026
singhmj-1
force-pushed
the
chore/fix-linting-issues
branch
from
April 3, 2026 05:18
75fc8c9 to
6d1e8ca
Compare
…ations Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com>
Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com>
Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com>
singhmj-1
force-pushed
the
chore/fix-linting-issues
branch
from
April 3, 2026 07:19
c6a573f to
77ef65f
Compare
Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com>
singhmj-1
changed the title
singhmj-1
changed the title
…man dispatch Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com>
Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com>
4 tasks
Signed-off-by: Viresh Navalli <viresh-r.navalli@capgemini.com>
Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com>
vireshnavalli
approved these changes
Apr 3, 2026
4 tasks
4 tasks
singhmj-1
added a commit
that referenced
this pull request
Apr 8, 2026
* chore: updates linting rules, adds other quality gates and fixes violations Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com> * chore: rectifies the linter issues in the code Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com> * chore: fixes linting issue in package manager Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com> * chore: removes an incorrect test case file Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com> * ci: adds option to override sanity workflow environment variables in man dispatch Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com> * ci: adds step in sanity workflow to verify dns working properly Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com> * ci: adds hosts block to coreDNS isntead of reading from a file Signed-off-by: Viresh Navalli <viresh-r.navalli@capgemini.com> * ci: read whole coredns cm and applies hostname * chore: fixes linting issues in santiy workflow Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com> --------- Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com> Co-authored-by: vireshnavalli <viresh-r.navalli@capgemini.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #236 .