Skip to content

fix: Run legacy Android ASan on API 33 #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mrousavy wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −7
Draft

fix: Run legacy Android ASan on API 33 #1600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions .github/workflows/harness-android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,17 @@ on:
workflow_dispatch:
inputs:
device_api_level:
description: "Android API level for the emulator"
description: "Override the Android API level for both jobs"
required: false
default: "36"
type: string
device_profile:
description: "Device profile"
required: false
default: "pixel_7"
type: string
avd_name:
description: "AVD name"
description: "Override the AVD name for both jobs"
required: false
default: "Pixel_7_API_36"
type: string
push:
branches:
Expand Down Expand Up @@ -70,11 +68,8 @@ on:
- "apps/example/rn-harness.config.mjs"

env:
# Device configuration - can be overridden by workflow_dispatch inputs
DEVICE_API_LEVEL: ${{ github.event.inputs.device_api_level || '36' }}
DEVICE_ARCH: x86_64
DEVICE_PROFILE: ${{ github.event.inputs.device_profile || 'pixel_7' }}
AVD_NAME: ${{ github.event.inputs.avd_name || 'Pixel_7_API_36' }}
AVD_DISK_SIZE: 1G
AVD_HEAP_SIZE: 1G

Expand All @@ -90,8 +85,17 @@ jobs:
sanitizer:
- name: Default
gradle_property: ""
device_api_level: "36"
avd_name: Pixel_7_API_36
- name: ASan
gradle_property: "address"
# Keep legacy x86_64 ASan on the API 33 image verified in #1530.
# HWASan requires ARM64; this workflow uses an x86_64 emulator.
device_api_level: "33"
avd_name: Pixel_7_API_33
env:
DEVICE_API_LEVEL: ${{ github.event.inputs.device_api_level || matrix.sanitizer.device_api_level }}
AVD_NAME: ${{ github.event.inputs.avd_name || matrix.sanitizer.avd_name }}
steps:
- uses: actions/checkout@v7
with:
Expand Down
Loading