fix: Fail iOS TSan CI on sanitizer reports - #1599
Draft
mrousavy wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An instrumented iOS app can report a data race and continue running, so passing Harness assertions do not establish a clean TSan run. Set
SIMCTL_CHILD_TSAN_OPTIONS=halt_on_error=1:log_path=/tmp/nitro-tsanfor the TSan row, print and fail on any report files even if Harness passed, and upload the reports after failures.Validation:
halt_on_error=1it stopped before that marker and wrote a symbolized report.simctl launch --consolereturned zero in both cases, confirming the need to check report files explicitly. The exact workflow check exits 1 with the real report and 0 without reports. A clean instrumented simulator app creates no report files.actionlintandgit diff --checkpass. Full Harness CI runs on this PR.References: TSan runtime options, Harness 1.4.1 app-session handling.