fix(ios): avoid shared pointer Bool conversion in generated Swift bridges - #1585
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 4, 2026
mrousavy
marked this pull request as ready for review
September 5, 2026 09:48
mrousavy
force-pushed
the
fix/xcode-shared-pointer-bool
branch
from
September 5, 2026 11:47
4a0cbf9 to
dabcf7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the cached shared-pointer Bool conversion with a use_count() check in the Swift bridge generator, and regenerate the seven checked-in bridges. No API changes.
Current Xcode rejects Bool(fromCxx: cachedCxxPart) because the imported shared_ptr does not conform to CxxConvertibleToBool. This failed the unchanged iOS Release source in #1582: https://github.com/margelo/nitro/actions/runs/33857794566/job/100975015762
This is an independent prerequisite for the atomic stack: #1582 (example move), #1583 (benchmark app), #1584 (version guard). The correction was extracted from the earlier benchmark implementation so neither the move nor performance PR needs to contain it.
Validation