Enhance exception routes not exists - #91
Merged
Merged
Conversation
marcuxyz
force-pushed
the
test/enhance_exception_routes_not_exists
branch
from
July 11, 2026 22:48
5c3ff62 to
14ba991
Compare
There was a problem hiding this comment.
Pull request overview
This PR bumps the package version and introduces a custom exception when a user’s routes.py module cannot be imported, aiming to provide a clearer error message if routes are not defined.
Changes:
- Bump version from
0.3.0to0.3.1across package metadata and tests. - Add
RoutesModuleNotFoundErrorand raise it fromBlueprintBindingwhen importing{path}.routesfails. - Remove the legacy
BlueprintMiddlewareimplementation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_version_functional.py | Updates expected __version__ for the new release. |
| pyproject.toml | Bumps project version to 0.3.1. |
| flask_mvc/version.py | Bumps library __version__ to 0.3.1. |
| flask_mvc/core/exceptions.py | Adds RoutesModuleNotFoundError for missing routes module scenarios. |
| flask_mvc/middlewares/blueprint_binding.py | Wraps routes import to raise a clearer custom exception on missing routes module. |
| flask_mvc/middlewares/blueprint_middleware.py | Removes the old blueprint middleware implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom exception message for the user if the user doesn't create
routes.py.