Refresh install.xml format - #133
Merged
marcusgreen merged 1 commit intoJul 8, 2026
Merged
Conversation
Owner
|
Thank you Michaael, running via core unit tests is really useful. It pleases me greatly to contributions to my plugins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current install.xml file is in an old format which includes PREVIOUS and NEXT etc. It causes a failure of the core unit test
core\db\plugin_checks_test. This patch is just the install.xml resaved in XMLDB editor in Moodle 5.11) core\db\plugin_checks_test::test_db_install_file with data set "qtype_gapfill" ('qtype_gapfill', 'qtype', 'gapfill', '/var/www/html/public/question...apfill') XMLDB structure does not match the install.xml file in /var/www/html/public/question/type/gapfill/db/install.xml Failed asserting that two DOM documents are equal.