fix(build): make install-hooks installs the commit-msg normalizer hook - #193
Open
iamlasse wants to merge 2 commits into
Open
fix(build): make install-hooks installs the commit-msg normalizer hook#193iamlasse wants to merge 2 commits into
iamlasse wants to merge 2 commits into
Conversation
Add internal/commits with pure Normalize/validate functions enforcing the project's Conventional Commits rules (known type set, lowercase type, lowercase subject, 72-char subject limit, whitespace trimming, and 72-column body wrapping). Wire it into the CLI as 'nightshift commit normalize' (positional, --file, and stdin sources; --check to validate only), ship a commit-msg git hook under scripts/, and document the format and installation in docs/commit-messages.md. Nightshift-Task: commit-normalize Nightshift-Ref: https://github.com/marcus/nightshift
Extend the install-hooks target to also symlink scripts/commit-msg.sh into .git/hooks/commit-msg, mirroring the existing pre-commit pattern. This closes the enforcement gap where docs/commit-messages.md directed users to run 'make install-hooks' but the target only installed the pre-commit hook, leaving the Conventional Commits normalizer uninstalled. Update the help target to describe both hooks. Nightshift-Task: commit-normalize Nightshift-Ref: https://github.com/marcus/nightshift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/commit-messages.mdinstructs users to runmake install-hooksto install the commit-msg hook, but theinstall-hooksMakefile target only symlinkedscripts/pre-commit.sh— leaving the Conventional Commits normalizer hook (scripts/commit-msg.sh) uninstalled so it never ran on commits.Changes
install-hookstarget to alsoln -sf ../../scripts/commit-msg.sh .git/hooks/commit-msg, mirroring the existing pre-commit pattern.helptarget and the target's comment to describe both hooks.Verification
make install-hooksinstalls both.git/hooks/pre-commitand.git/hooks/commit-msg, each pointing at the correct script.go build ./...passes.go test ./...passes.Closes the enforcement gap described in `commit-normalize`.
Automated by nightshift