Feat/gh 133 dark mode - #143
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new theme JS and layout changes introduce concrete cross-browser/runtime and navigation regressions that should be fixed before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Implements system-aware dark mode styling across Gust’s Phoenix LiveView UI by switching templates and shared components to DaisyUI theme tokens, and adds client-side theme detection to keep Mermaid diagrams in sync with OS color-scheme changes.
Changes:
- Adds DaisyUI dark theme tokens and refactors UI surfaces/text/borders to
base-*/*-contentclasses for consistent theming. - Introduces JS-driven
data-themesyncing withprefers-color-scheme, plus Mermaid re-rendering on theme changes. - Updates branding assets (SVG logo) and adds a small LiveView test asserting theme-preference UI copy.
File summaries
| File | Description |
|---|---|
| apps/gust_web/test/gust_web/live/system_live_test.exs | Adds a UI-level assertion for the system theme preference section. |
| apps/gust_web/test/gust_web/live/dag_live_test.exs | Minor whitespace adjustment in assertions block. |
| apps/gust_web/priv/static/images/gust-logo.svg | Adds an SVG logo asset for improved theme/scale handling. |
| apps/gust_web/lib/gust_web/live/system_live.html.heex | Adds “Web UI” panel describing system-driven theme behavior. |
| apps/gust_web/lib/gust_web/live/secret_live/index.html.heex | Replaces hard-coded light colors with theme tokens on cards/forms. |
| apps/gust_web/lib/gust_web/live/run_live/index.html.heex | Refactors run list UI to theme-aware background/border/text tokens. |
| apps/gust_web/lib/gust_web/live/dag_summary_component.ex | Updates “Paused” badge styling to theme token colors. |
| apps/gust_web/lib/gust_web/live/dag_live/index.html.heex | Updates empty state styling to theme tokens. |
| apps/gust_web/lib/gust_web/live/dag_live/dashboard.html.heex | Refactors dashboard/log/table styling and simplifies Mermaid config to allow theme switching. |
| apps/gust_web/lib/gust_web/live/breadcrumbs_component.ex | Updates breadcrumbs container styling to theme tokens. |
| apps/gust_web/lib/gust_web/components/layouts.ex | Switches logo to SVG and adjusts sidebar/mobile branding markup. |
| apps/gust_web/lib/gust_web/components/core_components.ex | Makes shared table/header actions theme-aware via token classes. |
| apps/gust_web/assets/js/app.js | Adds system theme detection, sets data-theme, emits theme-change events, and re-renders Mermaid diagrams accordingly. |
| apps/gust_web/assets/css/app.css | Adds/updates DaisyUI theme definitions, focus-visible outline, and refactors many component styles to theme tokens. |
Review details
Suppressed comments (1)
apps/gust_web/lib/gust_web/components/layouts.ex:96
- The sidebar brand area is no longer a link. This removes a convenient navigation target and (on mobile) means tapping the logo/wordmark won’t close the sidebar as it did previously. Wrap the logo/wordmark back in a
link(reusing the existingsidebar__brand-linkstyles) and keep the close button separate.
<div class="sidebar__brand">
<img src={~g"/images/gust-logo.svg"} alt="Gust" class="sidebar__logo" />
<span class="gust-wordmark">Gust</span>
<button
type="button"
id="mobile-navigation-close"
class="sidebar__close"
aria-label="Close navigation"
phx-click={mobile_navigation(:closed)}
>
<.icon name="hero-x-mark" class="size-5" />
</button>
</div>
- Files reviewed: 13/15 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+378
to
+380
| .sidebar__footer { | ||
| @apply mt-auto border-t border-base-content/15 p-3; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #133