feat: mobile reponsive - #142
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The CSS introduces duplicated small-screen rules for the same selectors, which increases the risk of conflicting overrides and makes future maintenance error-prone.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR improves the app’s mobile responsiveness by introducing a mobile-friendly navigation pattern in the main layout and adding consistent horizontal scrolling containment for wide tables/grids, with corresponding LiveView test updates to assert the new structure.
Changes:
- Added a mobile app bar + slide-in sidebar behavior in the main layout, including JS commands to open/close the navigation.
- Introduced/standardized a
.table-viewportwrapper for horizontally-scrollable tables and the DAG dashboard run history grid. - Updated LiveView tests to assert the presence of new responsive/navigation DOM structure and updated element selectors.
File summaries
| File | Description |
|---|---|
| apps/gust_web/test/gust_web/live/secret_live_test.exs | Updates selectors/assertions to match new table viewport wrapper and textarea id. |
| apps/gust_web/test/gust_web/live/run_live_test.exs | Adjusts pagination adjacency assertion to account for new table-viewport class. |
| apps/gust_web/test/gust_web/live/dag_live_test.exs | Adds assertions for mobile navigation and responsive layout structure. |
| apps/gust_web/test/gust_web/live/dag_live_dashboard_test.exs | Adds assertion that run history is wrapped in a scrollable viewport container. |
| apps/gust_web/lib/gust_web/live/secret_live/index.html.heex | Wraps secrets table in .table-viewport and updates form usage to reference @form fields directly. |
| apps/gust_web/lib/gust_web/live/run_live/index.html.heex | Makes run search controls wrap on small screens and wraps runs table in .table-viewport. |
| apps/gust_web/lib/gust_web/live/dag_live/dashboard.html.heex | Wraps the task grid/run history area in a viewport container for horizontal scrolling on mobile. |
| apps/gust_web/lib/gust_web/live/breadcrumbs_component.ex | Tweaks breadcrumbs container classes to wrap more gracefully on small screens. |
| apps/gust_web/lib/gust_web/components/layouts.ex | Adds mobile app bar, backdrop, sidebar close behavior, and related JS helpers/ids for responsive navigation. |
| apps/gust_web/lib/gust_web/components/core_components.ex | Updates header layout to stack actions on small screens. |
| apps/gust_web/assets/css/app.css | Adds responsive layout rules, .table-viewport utility, and mobile navigation styling. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Owner
Author
|
closes #125 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.