feat: remove error section when run is running - #130
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new progress indicator and status modifier classes have concrete accessibility and class-generation issues that should be corrected before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the DAG dashboard UI to avoid showing stale/persisted task error details while a task is actively running, and adds/extends “running” visual indicators to reflect live status changes more clearly.
Changes:
- Hide the task error section when
@item_status == :runningin the dashboard’s selected-item details. - Add a running-status progress/stripe indicator and new status-based CSS selectors.
- Update and expand LiveView/component tests to assert the new behavior and CSS class usage.
File summaries
| File | Description |
|---|---|
| apps/gust_web/test/gust_web/live/run_live_test.exs | Makes pagination test deterministic by controlling inserted_at ordering and asserting correct page contents. |
| apps/gust_web/test/gust_web/live/dag_live_dashboard_test.exs | Adds coverage to ensure task errors are hidden while running and verifies running class/state transitions in the dashboard. |
| apps/gust_web/test/gust_web/components/dag_run_components_test.exs | Updates selectors to match new status modifier class (task-grid-cell--running). |
| apps/gust_web/lib/gust_web/live/dag_live/dashboard.html.heex | Hides error section during running and introduces the status progress element. |
| apps/gust_web/lib/gust_web/components/dag_run_components.ex | Refactors task cell class generation to include a status modifier class. |
| apps/gust_web/assets/css/app.css | Adds animated stripe styling for running/retrying plus reduced-motion overrides. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.