Skip to content

Feat/gh 127 search run per params - #129

Merged
marciok merged 3 commits into
v0.1.38-devfrom
feat/GH-127-search-run-per-params
Aug 24, 2026
Merged

Feat/gh 127 search run per params#129
marciok merged 3 commits into
v0.1.38-devfrom
feat/GH-127-search-run-per-params

Conversation

@marciok

@marciok marciok commented Aug 24, 2026

Copy link
Copy Markdown
Owner

fix #127

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Offset pagination is not deterministically ordered (ties on inserted_at can cause missing/duplicate rows across pages), which risks incorrect pagination behavior for the new filtering/pagination UX.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Implements Issue #127 by adding server-side filtering of DAG runs based on run parameter keys/values, wiring the search state through the Run index LiveView (including URL persistence), and updating UI + tests to cover parameter search combined with status filtering and pagination.

Changes:

  • Add :params_search support to Flows.get_dag_by_name_with_runs!/2 and Flows.count_runs_on_dag/3 for server-side parameter key/value matching.
  • Extend the runs index LiveView to parse/store params_search, push URL patches on search/status/page changes, and filter real-time inserts against the active filters.
  • Update the runs index UI (search control + compact pagination) and add/extend tests for matches, no matches, clearing, status combos, pagination, and counts.
File summaries
File Description
apps/gust/test/flows_test.exs Adds unit tests for server-side params search behavior, including pagination + status interactions and blank search handling.
apps/gust/lib/gust/flows.ex Adds :params_search filtering to runs preload and run counting queries.
apps/gust_web/test/gust_web/live/run_live_test.exs Adds LiveView tests verifying URL persistence, match/no-match states, clearing behavior, pagination preservation, and real-time insert filtering under params search.
apps/gust_web/lib/gust_web/live/run_live/index.html.heex Adds parameter search UI and replaces the page select with compact pagination buttons.
apps/gust_web/lib/gust_web/live/run_live/index.ex Wires params_search through LiveView params/events, URL generation, and PubSub-driven run list updates.
apps/gust_web/assets/css/app.css Adds styling helpers for the new search and status filter forms.
Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread apps/gust/lib/gust/flows.ex
Comment thread apps/gust_web/lib/gust_web/live/run_live/index.html.heex
@marciok
marciok merged commit eaa4359 into v0.1.38-dev Aug 24, 2026
4 checks passed
@marciok
marciok deleted the feat/GH-127-search-run-per-params branch August 24, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants