Feat/gh 127 search run per params - #129
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Offset pagination is not deterministically ordered (ties on inserted_at can cause missing/duplicate rows across pages), which risks incorrect pagination behavior for the new filtering/pagination UX.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Implements Issue #127 by adding server-side filtering of DAG runs based on run parameter keys/values, wiring the search state through the Run index LiveView (including URL persistence), and updating UI + tests to cover parameter search combined with status filtering and pagination.
Changes:
- Add
:params_searchsupport toFlows.get_dag_by_name_with_runs!/2andFlows.count_runs_on_dag/3for server-side parameter key/value matching. - Extend the runs index LiveView to parse/store
params_search, push URL patches on search/status/page changes, and filter real-time inserts against the active filters. - Update the runs index UI (search control + compact pagination) and add/extend tests for matches, no matches, clearing, status combos, pagination, and counts.
File summaries
| File | Description |
|---|---|
| apps/gust/test/flows_test.exs | Adds unit tests for server-side params search behavior, including pagination + status interactions and blank search handling. |
| apps/gust/lib/gust/flows.ex | Adds :params_search filtering to runs preload and run counting queries. |
| apps/gust_web/test/gust_web/live/run_live_test.exs | Adds LiveView tests verifying URL persistence, match/no-match states, clearing behavior, pagination preservation, and real-time insert filtering under params search. |
| apps/gust_web/lib/gust_web/live/run_live/index.html.heex | Adds parameter search UI and replaces the page select with compact pagination buttons. |
| apps/gust_web/lib/gust_web/live/run_live/index.ex | Wires params_search through LiveView params/events, URL generation, and PubSub-driven run list updates. |
| apps/gust_web/assets/css/app.css | Adds styling helpers for the new search and status filter forms. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #127