Add helm chart - #1
Conversation
|
Hi giggio, |
|
No problem, it is working from my fork. Whenever you have the time! |
| | `image.repository` | Image name | `marcinbudny/servicebus_exporter` | | ||
| | `image.tag` | Image tag | `{TAG_NAME}` | | ||
| | `image.pullPolicy` | Image pull policy | `IfNotPresent` | | ||
| | `image.pullSecrets` | Specify docker-registry secret names as an array | `[]` (does not add image pull secrets to deployed pods) | |
There was a problem hiding this comment.
How is this different from imagePullSecrets?
| @@ -0,0 +1,2 @@ | |||
| # fake value so the chart installs | |||
There was a problem hiding this comment.
Can you explain purpose of this file?
| labels: | ||
| {{ include "servicebusexporter.labels" . | indent 4 }} | ||
| spec: | ||
| replicas: {{ .Values.replicaCount }} |
There was a problem hiding this comment.
It makes little sense to use more than one replica, since all of them will be scraped separately. That will result in multiple copies of the metrics and they will be difficult to separate.
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| {{- if .Values.addPromAnnotations }} | ||
| annotations: | ||
| prometheus.io/scrape: "true" |
There was a problem hiding this comment.
Allowing any custom annotations may be reasonable. The prometheus.io/* annotations are the default for discovery, but it can also be based on other annotations depending on the config.
| | `tolerations` | List of node taints to tolerate | `[]` | | ||
| | `affinity` | Map of node/pod affinities | `{}` | | ||
|
|
||
| The first three parameters and `service.port` map to the command line arguments for the binary. |
There was a problem hiding this comment.
They are mapped to env variables
|
Hi giggio, However I think it would make more sense if you contributed this chart to the official Helm repo at https://github.com/helm/charts They have several exporter charts already. |
2 participants
This is a first iteration to try to create a Helm chart for the service bus exporter. We can discuss it and I'll make the changes you need.
This is self hosted on Github pages, I reached out to the Kubeapps people and they did not reply. See the index file at: https://giggio.github.io/servicebus_exporter/index.yaml
A release was created to make it work: https://github.com/giggio/servicebus_exporter/releases/tag/servicebusexporter-0.0.1
I used the chart releaser from the Helm project to create the index and the release on Github: https://github.com/helm/chart-releaser
Please let me know what you think and we can move it from there.