Skip to content

fix: add 30s network timeout to callSoloditAPI #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EFCCWEB3 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add 30s network timeout to callSoloditAPI #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 37 additions & 24 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,35 +178,48 @@ interface SoloditResponse {
async function callSoloditAPI(body: SoloditRequest): Promise<SoloditResponse> {
await rateLimiter.waitIfNeeded();

const res = await fetch(`${API_BASE}/findings`, {
method: "POST",
headers: {
"Content-Type": "application/json",
"X-Cyfrin-API-Key": API_KEY!,
},
body: JSON.stringify(body),
});

rateLimiter.update(res.headers);

if (!res.ok) {
const errBody = await res.text();
if (res.status === 401) {
const controller = new AbortController();
const timeoutId = setTimeout(() => controller.abort(), 30000); // 30s timeout

try {
const res = await fetch(`${API_BASE}/findings`, {
method: "POST",
headers: {
"Content-Type": "application/json",
"X-Cyfrin-API-Key": API_KEY!,
},
body: JSON.stringify(body),
signal: controller.signal,
});

clearTimeout(timeoutId);
rateLimiter.update(res.headers);

if (!res.ok) {
const errBody = await res.text();
if (res.status === 401) {
throw new Error(
`Invalid API key. Get a new one at: https://solodit.cyfrin.io → Profile → API Keys`
);
}
if (res.status === 429) {
throw new Error(
`Rate limited. Limit resets at ${new Date(rateLimiter.status().resetAt).toISOString()}. Try again shortly.`
);
}
throw new Error(
`Invalid API key. Get a new one at: https://solodit.cyfrin.io → Profile → API Keys`
`Solodit API error (${res.status}): ${errBody.slice(0, 200)}`
);
}
if (res.status === 429) {
throw new Error(
`Rate limited. Limit resets at ${new Date(rateLimiter.status().resetAt).toISOString()}. Try again shortly.`
);

return (await res.json()) as SoloditResponse;
} catch (error: any) {
clearTimeout(timeoutId);
if (error.name === 'AbortError') {
throw new Error('Request timeout - Solodit API did not respond within 30 seconds');
}
throw new Error(
`Solodit API error (${res.status}): ${errBody.slice(0, 200)}`
);
throw error;
}

return (await res.json()) as SoloditResponse;
}

// ── Formatters ──────────────────────────────────────────────────────────────
Expand Down