Skip to content

Initial support for Django 1.10 and Python 3 - #1

Open
meredithdutton wants to merge 1 commit into
marcanpilami:masterfrom
meredithdutton:py3-dj1.10
Open

Initial support for Django 1.10 and Python 3#1
meredithdutton wants to merge 1 commit into
marcanpilami:masterfrom
meredithdutton:py3-dj1.10

Conversation

@meredithdutton

@meredithdutton meredithdutton commented Feb 25, 2017

Copy link
Copy Markdown

This:

  • replaces except Exception, e with except Exception as e for Py3 support
  • moves to django.shortcuts.render from render_to_response for Dj1.10 support
  • changes the requirement to include Django 1.9 and Django 1.10
  • fixes an import to try the Py3 module path
  • stops using django.conf.urls.patterns

This should maintain Django 1.8 support (having looked back through the Django docs)

@maiksprenger

Copy link
Copy Markdown

Note that there's @koriaf's fork, and a fork based on that which probably is the best candidate for Python 3 and Django 1.11 support: https://github.com/py-pa/django-oidc

@koriaf

koriaf commented Jun 30, 2017

Copy link
Copy Markdown

may be some day someone will be able to merge all these forks to single codebase which works fine for both Pythons. :-)

@vstoykov

Copy link
Copy Markdown

At that day Python 2 will probably EOL and only Python 3+ compatible version would be needed 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants