Fix browser database seeding failure - #134
Conversation
- Fixes a regression where the browser database failed to populate due to missing `is_reusable` column in the `INSERT` statement for `resource_definitions`. - The column is required by the schema (`NOT NULL`) and was erroneously removed in a previous commit. - Updates `SqliteService.seedDefinitionCatalogs` to include `is_reusable` and bind it correctly.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes a critical issue where the browser-side SQLite database would fail to populate with default resources if the prebuilt database failed to load. The fallback seeding logic was missing the
is_reusablecolumn in theINSERTstatement, which is a required field in the schema. This caused the seeding transaction to fail silently (caught and logged), resulting in an empty database in the deployed application (GitHub Pages).Changes:
is_reusableto theINSERT INTO resource_definitionsSQL statement inpraxis/web-client/src/app/core/services/sqlite.service.ts.def.is_reusable.PR created automatically by Jules for task 1274029087648840399 started by @maraxen