Merge updates from KineticPreProcessor/KPP into your KPP main branch - #1
Open
yantosca wants to merge 2 commits into
Open
Merge updates from KineticPreProcessor/KPP into your KPP main branch#1yantosca wants to merge 2 commits into
yantosca wants to merge 2 commits into
Conversation
int/implicit12.f90 - Update comments - Trimmed trailing whitespace - Add logicals Do_Update_RCONST, Do_Update_PHOTO, Do_Update_SUN, which are assigned by calling Integrator_Update_Options - Add VAR and FIX pointers to point to active and fixed species in the C array - In routine SDIRK, save the final time in RSTATUS(1) and the H value in RSTATUS(2). Otherwise, this won't timestep forward. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
examples/implicit12.kpp - KPP file for the small_strato mechanism and implicit12 solver .ci-pipelines/ci-common-defs.sh - Added F90_implicit12 to the list of C-I tests ci-tests/F90_implicit12.kpp - Symbolic link to examples/implicit12.kpp CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @maqsoodrajput, I wanted to bring the changes I've made for the implicit12 solver back into your main branch, so that the PR KineticPreProcessor#101 will be updated accordingly. I added a few fixes and also the C-I test for the implicit12 solver.
Tagging @RolfSander @obin1 @jimmielin