feat(rust): add `FPF128` with `u32::from_le_bytes` by CommanderStorm · Pull Request #1611 · maplibre/maplibre-tile-spec

CommanderStorm · 2026-09-02T19:08:49Z

No description provided.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

codecov · 2026-09-03T14:55:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (stack-v2-strings@d4ba2a2). Learn more about missing BASE report.

Additional details and impacted files

@@                 Coverage Diff                 @@
##             stack-v2-strings    #1611   +/-   ##
===================================================
  Coverage                    ?   67.59%           
  Complexity                  ?     1261           
===================================================
  Files                       ?      154           
  Lines                       ?    10912           
  Branches                    ?     2688           
===================================================
  Hits                        ?     7376           
  Misses                      ?     2356           
  Partials                    ?     1180

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-09-03T15:19:09Z

Performance Comparison

Performance Comparison `main` → `stack-v2-fpf`

Total Elapsed Time: 2.18s → 2.18s (-0.1%)
CPU Baseline: 82.11µs → 80.87µs (-1.5%)
Benchmark ID: mlt-convert

timing - Function execution time metrics.

+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| Function                             | Calls                        | Avg                            | P95                            | Total                          | % Total                      |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| optimizer::encode                    | 14096 → 14096 (+0.0%)        | 531.68µs → 529.07µs (-0.5%)    | 2.31ms → 2.30ms (-0.4%)        | 7.49s → 7.46s (-0.4%)          | 343.67% → 342.25% (-0.4%)    |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| optimizer::encode_into               | 28192 → 28192 (+0.0%)        | 170.85µs → 168.37µs (-1.5%)    | 728.58µs → 717.31µs (-1.5%)    | 4.82s → 4.75s (-1.5%)          | 220.88% → 217.84% (-1.4%)    |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| encode01::write_to                   | 28192 → 28192 (+0.0%)        | 135.41µs → 132.94µs (-1.8%)    | 647.17µs → 639.49µs (-1.2%)    | 3.82s → 3.75s (-1.8%)          | 175.05% → 171.99% (-1.7%)    |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| writer::with                         | 1573034 → 1573034 (+0.0%)    | 1.68µs → 1.65µs (-1.8%)        | 2.29µs → 2.33µs (+1.7%)        | 2.65s → 2.60s (-1.9%)          | 121.43% → 119.28% (-1.8%)    |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| mlt::main                            | 1 → 1 (+0.0%)                | 2.18s → 2.18s (+0.0%)          | 2.18s → 2.18s (+0.0%)          | 2.18s → 2.18s (+0.0%)          | 100.00% → 100.00% (+0.0%)    |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| optimizer::analyze                   | 14096 → 14096 (+0.0%)        | 120.99µs → 122.09µs (+0.9%)    | 619.52µs → 622.59µs (+0.5%)    | 1.71s → 1.72s (+0.6%)          | 78.20% → 78.98% (+1.0%)      |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| shared_dict::group_string_properties | 14096 → 14096 (+0.0%)        | 116.59µs → 117.67µs (+0.9%)    | 602.62µs → 598.01µs (-0.8%)    | 1.64s → 1.66s (+1.2%)          | 75.36% → 76.12% (+1.0%)      |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| streams::dict_may_be_beneficial      | 28192 → 28192 (+0.0%)        | 48.60µs → 47.31µs (-2.7%)      | 217.47µs → 211.20µs (-2.9%)    | 1.37s → 1.33s (-2.9%)          | 62.83% → 61.21% (-2.6%)      |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| encode::write_prop                   | 116572 → 116572 (+0.0%)      | 7.86µs → 7.90µs (+0.5%)        | 18.29µs → 18.37µs (+0.4%)      | 916.77ms → 921.49ms (+0.5%)    | 42.04% → 42.29% (+0.6%)      |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| tile::from_tile                      | 28192 → 28192 (+0.0%)        | 19.71µs → 19.71µs (+0.0%)      | 78.78µs → 77.06µs (-2.2%)      | 555.62ms → 555.59ms (-0.0%)    | 25.48% → 25.50% (+0.1%)      |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| shared_dict::write_shared_dict       | 24002 → 24002 (+0.0%)        | 22.27µs → 22.49µs (+1.0%)      | 54.75µs → 54.49µs (-0.5%)      | 534.52ms → 539.73ms (+1.0%)    | 24.51% → 24.77% (+1.1%)      |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| strings::write_str_col               | 57070 → 57070 (+0.0%)        | 5.37µs → 5.35µs (-0.4%)        | 12.97µs → 13.00µs (+0.2%)      | 306.72ms → 305.14ms (-0.5%)    | 14.07% → 14.00% (-0.5%)      |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| sort::curve_params                   | 14096 → 14096 (+0.0%)        | 16.85µs → 18.14µs (+7.7%)      | 79.17µs → 82.11µs (+3.7%)      | 237.56ms → 255.64ms (+7.6%)    | 10.89% → 11.73% (+7.7%)      |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| strings::fsst_try_train              | 40536 → 40536 (+0.0%)        | 3.38µs → 3.47µs (+2.7%)        | 80.00ns → 80.00ns (+0.0%)      | 136.82ms → 140.61ms (+2.8%)    | 6.27% → 6.45% (+2.9%)        |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| strings::write_str_plain             | 57070 → 57070 (+0.0%)        | 1.45µs → 1.45µs (+0.0%)        | 3.58µs → 3.61µs (+0.8%)        | 82.47ms → 82.63ms (+0.2%)      | 3.78% → 3.79% (+0.3%)        |
+--------------------------------------+------------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+

alloc-bytes - Exclusive allocation bytes by each function (excluding nested calls).

+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| Function                             | Calls                        | Avg                          | P95                            | Total                          | % Total                    |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| tile::from_tile                      | 28192 → 28192 (+0.0%)        | 44.1 KB → 44.1 KB (+0.0%)    | 238.5 KB → 238.5 KB (+0.0%)    | 1.2 GB → 1.2 GB (+0.0%)        | 23.23% → 23.23% (+0.0%)    |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| optimizer::encode                    | 14096 → 14096 (+0.0%)        | 86.2 KB → 86.2 KB (+0.0%)    | 159.2 KB → 159.2 KB (+0.0%)    | 1.2 GB → 1.2 GB (+0.0%)        | 22.69% → 22.69% (+0.0%)    |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| writer::with                         | 1573034 → 1573034 (+0.0%)    | 723 B → 723 B (+0.0%)        | 25.0 KB → 25.0 KB (+0.0%)      | 1.1 GB → 1.1 GB (+0.0%)        | 20.74% → 20.74% (+0.0%)    |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| strings::fsst_try_train              | 40536 → 40536 (+0.0%)        | 16.8 KB → 16.8 KB (+0.0%)    | 3.6 MB → 3.6 MB (+0.0%)        | 664.5 MB → 664.5 MB (+0.0%)    | 12.70% → 12.70% (+0.0%)    |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| shared_dict::group_string_properties | 14096 → 14096 (+0.0%)        | 30.3 KB → 30.3 KB (+0.0%)    | 171.6 KB → 171.6 KB (+0.0%)    | 416.9 MB → 416.9 MB (+0.0%)    | 7.97% → 7.97% (+0.0%)      |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| strings::write_str_col               | 57070 → 57070 (+0.0%)        | 4.1 KB → 4.1 KB (+0.0%)      | 11.0 KB → 11.0 KB (+0.0%)      | 227.7 MB → 227.7 MB (+0.0%)    | 4.35% → 4.35% (+0.0%)      |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| encode01::write_to                   | 28192 → 28192 (+0.0%)        | 7.5 KB → 7.5 KB (+0.0%)      | 35.7 KB → 35.7 KB (+0.0%)      | 206.0 MB → 206.0 MB (+0.0%)    | 3.94% → 3.94% (+0.0%)      |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| shared_dict::write_shared_dict       | 24002 → 24002 (+0.0%)        | 6.6 KB → 6.6 KB (+0.0%)      | 37.4 KB → 37.4 KB (+0.0%)      | 154.9 MB → 154.9 MB (+0.0%)    | 2.96% → 2.96% (+0.0%)      |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| strings::write_raw_str_data          | 137744 → 137744 (+0.0%)      | 122 B → 122 B (+0.0%)        | 9.0 KB → 9.0 KB (+0.0%)        | 16.1 MB → 16.1 MB (+0.0%)      | 0.31% → 0.31% (+0.0%)      |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| streams::build_morton_dict           | 362 → 362 (+0.0%)            | 44.6 KB → 44.6 KB (+0.0%)    | 89.9 KB → 89.9 KB (+0.0%)      | 15.8 MB → 15.8 MB (+0.0%)      | 0.30% → 0.30% (+0.0%)      |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| optimizer::analyze                   | 14096 → 14096 (+0.0%)        | 1.0 KB → 1.0 KB (+0.0%)      | 6.5 KB → 6.5 KB (+0.0%)        | 14.0 MB → 14.0 MB (+0.0%)      | 0.27% → 0.27% (+0.0%)      |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| streams::build_hilbert_dict          | 362 → 362 (+0.0%)            | 25.9 KB → 25.9 KB (+0.0%)    | 90.7 KB → 90.7 KB (+0.0%)      | 9.2 MB → 9.2 MB (+0.0%)        | 0.18% → 0.18% (+0.0%)      |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| streams::dict_may_be_beneficial      | 28192 → 28192 (+0.0%)        | 256 B → 256 B (+0.0%)        | 256 B → 256 B (+0.0%)          | 6.9 MB → 6.9 MB (+0.0%)        | 0.13% → 0.13% (+0.0%)      |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| strings::write_str_plain             | 57070 → 57070 (+0.0%)        | 69 B → 69 B (+0.0%)          | 240 B → 240 B (+0.0%)          | 3.8 MB → 3.8 MB (+0.0%)        | 0.07% → 0.07% (+0.0%)      |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+
| encode::write_prop                   | 116572 → 116572 (+0.0%)      | 27 B → 27 B (+0.0%)          | 256 B → 256 B (+0.0%)          | 3.1 MB → 3.1 MB (+0.0%)        | 0.06% → 0.06% (+0.0%)      |
+--------------------------------------+------------------------------+------------------------------+--------------------------------+--------------------------------+----------------------------+

Threads

No threads to compare

Generated with hotpath-rs

Per-tile encoded size diff

zoom	tiles	prev_total	curr_total
0	1	71471	71471
1	4	220986	220986
2	16	615003	615003
3	64	1653851	1653851
4	256	3828904	3828904
5	1024	9716821	9716821
6	4096	32401914	32401914
ALL	5461	48508950	48508950

Top 3 improvements

Top 3 degradations

github-code-quality · 2026-09-05T00:23:57Z

Code Coverage Overview

Languages: TypeScript, Java

TypeScript / code-coverage/vitest

The overall line coverage in commit 1539b3d in the stack-v2-fpf branch remains at 97%, unchanged from commit 3c4c0c6 in the stack-v2-strings branch.

Java / code-coverage/jacoco

The overall line coverage in commit 1539b3d in the stack-v2-fpf branch is 67%. Line coverage data for the stack-v2-strings branch is not yet available.

Show a line coverage summary of the most covered files.

File	`stack-v2-strings`	`stack-v2-fpf` 1539b3d	+/-
`java/mlt-core/s...odingUtils.java`	—	99%	—
`java/mlt-core/s...rtyEncoder.java`	—	95%	—
`java/mlt-core/s...tryDecoder.java`	—	95%	—
`java/mlt-core/s...pareHelper.java`	—	95%	—
`java/mlt-core/s...rtyEncoder.java`	—	90%	—
`java/mlt-core/s...rtyDecoder.java`	—	88%	—
`java/mlt-cli/sr...eCommandLine.kt`	—	87%	—
`java/mlt-core/s...tConverter.java`	—	87%	—
`java/mlt-core/s...tryEncoder.java`	—	84%	—
`java/mlt-core/s...gerEncoder.java`	—	63%	—

_{Updated September 07, 2026 11:10 UTC}

Generated by rust/scripts/hexdump_stack.py. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

for more information, see https://pre-commit.ci

CommanderStorm marked this pull request as ready for review September 2, 2026 20:44

Copilot AI lite review requested due to automatic review settings September 2, 2026 20:44

Copilot AI reviewed Sep 2, 2026

CommanderStorm force-pushed the stack-v2-fpf branch from 1a60c12 to e9e5487 Compare September 3, 2026 14:28

CommanderStorm force-pushed the stack-v2-fpf branch from e9e5487 to 88b9119 Compare September 3, 2026 15:16

CommanderStorm force-pushed the stack-v2-fpf branch from 88b9119 to e04bcfc Compare September 3, 2026 17:53

CommanderStorm force-pushed the stack-v2-fpf branch from e04bcfc to 37a98ea Compare September 3, 2026 21:13

CommanderStorm force-pushed the stack-v2-fpf branch 2 times, most recently from 3ee1bb3 to eb1f570 Compare September 4, 2026 09:20

CommanderStorm force-pushed the stack-v2-fpf branch 2 times, most recently from 8976bd3 to 5671930 Compare September 4, 2026 12:25

CommanderStorm force-pushed the stack-v2-fpf branch from 35c4302 to 9e683ca Compare September 4, 2026 13:43

CommanderStorm force-pushed the stack-v2-fpf branch from 9e683ca to 3735124 Compare September 4, 2026 14:03

CommanderStorm force-pushed the stack-v2-fpf branch from 3735124 to 0ae2040 Compare September 4, 2026 14:15

CommanderStorm force-pushed the stack-v2-fpf branch from 0ae2040 to e3fc162 Compare September 4, 2026 23:59

CommanderStorm force-pushed the stack-v2-fpf branch from e3fc162 to 0bcf5f4 Compare September 5, 2026 13:14

CommanderStorm force-pushed the stack-v2-fpf branch from 0bcf5f4 to 426e8bb Compare September 5, 2026 13:42

CommanderStorm and others added 3 commits September 7, 2026 13:04

impl

764d5cc

chore(rust): refresh .mlt hexdumps

5cb127a

Generated by rust/scripts/hexdump_stack.py. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

1539b3d

for more information, see https://pre-commit.ci

CommanderStorm force-pushed the stack-v2-fpf branch from 426e8bb to 1539b3d Compare September 7, 2026 11:06

Navigation Menu

Uh oh!

feat(rust): add `FPF128` with `u32::from_le_bytes` - #1611

feat(rust): add `FPF128` with `u32::from_le_bytes`#1611
CommanderStorm wants to merge 3 commits into
stack-v2-stringsfrom
stack-v2-fpf

CommanderStorm commented Sep 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

codecov Bot commented Sep 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 3, 2026 •

edited

Loading

Performance Comparison `main` → `stack-v2-fpf`

timing - Function execution time metrics.

alloc-bytes - Exclusive allocation bytes by each function (excluding nested calls).

Threads

Top 3 improvements

Top 3 degradations

Uh oh!

github-code-quality Bot commented Sep 5, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

CommanderStorm commented Sep 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance Comparison main → stack-v2-fpf

timing - Function execution time metrics.

alloc-bytes - Exclusive allocation bytes by each function (excluding nested calls).

Threads

Top 3 improvements

Top 3 degradations

Uh oh!

github-code-quality Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Overview

TypeScript / code-coverage/vitest

Java / code-coverage/jacoco

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Sep 3, 2026 •

edited

Loading

github-actions Bot commented Sep 3, 2026 •

edited

Loading

Performance Comparison `main` → `stack-v2-fpf`

github-code-quality Bot commented Sep 5, 2026 •

edited

Loading