Core: Add support for colorized SDF fill patterns - #4551
Conversation
Bloaty Results (iOS) 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-4551-compared-to-main.txt |
|
@louwers maplibre/maplibre-gl-js#8239 has now been merged, and all four render tests from it are ported here. The fixes for the Linux, WebGPU, and Vulkan failures are also pushed. Could you kick off another workflow run when you have a chance? Thanks! |
Bloaty Results 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-4551-compared-to-main.txtCompared to d387090 (legacy) Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-4551-compared-to-legacy.txt |
|
Benchmark Results ⚡ Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-4551-compared-to-main.txt |
|
|
||
| bool shouldWarnAboutMixedSDFPatterns(const std::string& layerID) { | ||
| static std::mutex mutex; | ||
| static mln::unordered_set<std::string> warnedLayers; |
There was a problem hiding this comment.
Is there any way to avoid these static variables?
There was a problem hiding this comment.
Addressed in d5a7656. The warning suppression set now belongs to each FillBucket, so there are no function-local statics or mutex. The test verifies that repeated mismatches warn once within a bucket and that separate buckets do not share warning state.
Description
Implements Support colorized SDF fill patterns.
When a
fill-patternreferences an SDF image, the renderer now:fill-coloras the pattern foreground color.fill-opacity.Implementation
fill-colortogether withfill-patternin the bundled style specification.ImagePositionand the pattern atlas.No public API changes are required.
Testing
fill-opacityRelated work
AI assistance
OpenAI Codex was used for implementation review, warning deduplication, regression testing, and generated documentation checks. The contributor has reviewed and verified the submitted changes before marking this draft ready for review.
Fixes #4526