iOS: Clear transient edge padding for unchanged camera - #4537
Open
miakh wants to merge 1 commit into
Open
Conversation
Author
|
Reproduction on iPhone 17 Pro Simulator (iOS 26.5), recorded 30 Aug 2026. Red dot = target coordinate; blue cross = screen center. After clearing padding with the same camera, current main remains 90 pt offset; this branch returns to 0 pt. Before (current main): before-iphone17.mp4After (this branch): after-iphone17.mp4 |
miakh
force-pushed
the
fix/4449-clear-transient-edge-padding
branch
from
September 1, 2026 21:37
05d2bde to
f3471bd
Compare
miakh
marked this pull request as ready for review
September 1, 2026 21:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4449.
setCameranow compares the requested effective padding with the padding currently held by the core map before treating an unchanged camera as a no-op. This allows zeroedgePaddingto clear earlier transient padding.The regression test applies bottom padding, sets the same camera again with zero padding, and verifies that only
contentInsetremains.Tested with:
bazel test //platform/ios/test:ios_test --test_output=errors --//:renderer=metal --test_filter="MLNMapViewGestureRecognizerTests/testSetCameraClearsTransientEdgePaddingWhenCameraIsUnchanged"AI usage: OpenAI Codex (GPT-5) assisted with the implementation and tests under human supervision.